Skip to content

Fix: update Na and Tw to new face card region #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reconman merged 4 commits into from
Mar 24, 2026
+2 −6
Merged

Fix: update Na and Tw to new face card region #2201

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eda3a35
Update BattleScreenLocations.kt
vybze Mar 24, 2026
836b69b
Update BattleScreenLocations.kt
vybze Mar 24, 2026
37f2308
Update BattleScreenLocations.kt
vybze Mar 24, 2026
a89cb2d
Making changes since all servers uses the same face check location now
vybze Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ts/src/main/java/io/github/fate_grand_automata/scripts/locations/BattleScreenLocations.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class BattleScreenLocations @Inject constructor(

val servantDetailsFaceCardRegion = when (gameServer) {
// FGO JP 2024-04-12 updated the UI resulting in the bricking of the face card detection
is GameServer.Jp, GameServer.Cn, is GameServer.Kr -> Region(-685, 410, 110, 60).xFromCenter()
is GameServer.Jp, GameServer.Cn, is GameServer.Kr, is GameServer.En -> Region(-685, 410, 110, 60).xFromCenter()
Copy link
Copy Markdown
Collaborator

@ArthurKun21 ArthurKun21 Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to Tw only here and move the comment to else

Copy link
Copy Markdown
Collaborator Author

@vybze vybze Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

else -> Region(-685, 330, 110, 60).xFromCenter()
}

Expand Down
Loading