fix: change CDN pricing from monthly to usage-based egress model #324
+28
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace monthly CDN subscription pricing with per-TiB egress rates - Remove automatic CDN payment rail updates when storage size changes - Update ServicePricing struct to reflect usage-based pricing model - Refactor calculateRatesPerEpoch to only handle storage rates BREAKING CHANGE: ServicePricing API changed - pricePerTiBPerMonthWithCDN replaced with pricePerTiBCdnEgress and pricePerTiBCacheMissEgress fields
pyropy
requested review from
ZenGround0,
bajtos,
hugomrdias,
jennijuju,
juliangruber,
rjan90,
rvagg and
wjmelements
and removed request for
ZenGround0 and
juliangruber
|
regarding the PR title: I think this is a fix and not a refactor |
pyropy
changed the title
Should I also ammend the commit and rename the branch? WDYT? |
wjmelements
reviewed
Oct 23, 2025
| uint256 private immutable CACHE_MISS_PRICE_PER_TIB_PER_MONTH; // .5 USDFC per TiB per month for CDN with correct decimals | ||
| uint256 private immutable CDN_PRICE_PER_TIB_PER_MONTH; // .5 USDFC per TiB per month for CDN with correct decimals | ||
| uint256 private immutable CDN_EGRESS_PRICE_PER_TIB; // 7 USDFC per TiB of CDN egress | ||
| uint256 private immutable CACHE_MISS_EGRESS_PRICE_PER_TIB; // 7 USDFC per TiB of cache miss egress |
There was a problem hiding this comment.
are these too low? AWS egress seems to charge about 10x higher. Does this align with your own costs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
ServicePricingAPI changed -pricePerTiBPerMonthWithCDNreplaced withpricePerTiBCdnEgressandpricePerTiBCacheMissEgressfieldsCloses #323