Add basic apphosting.yaml in next.js and angular starter templates. #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
requested review from
Yuangwang,
jamesdaniels,
leoortizz and
tonyjhuang
as code owners
Yuangwang
approved these changes
Sep 13, 2024
inlined
reviewed
Sep 16, 2024
| @@ -0,0 +1,23 @@ | |||
| # Settings for Backend (on Cloud Run). | |||
There was a problem hiding this comment.
Maybe we should have a header explaining the use of environment-specific apphosting.yaml overrides?
There was a problem hiding this comment.
I think I'd rather point the users to public doc so we don't have 2 separate places to track documentations on how to use env specific overrides.
| # Settings for Backend (on Cloud Run). | ||
| # See https://firebase.google.com/docs/app-hosting/configure#cloud-run. | ||
| runConfig: | ||
| minInstances: 0 |
There was a problem hiding this comment.
why does Angular comment out all values but Nex.tjs does not?
There was a problem hiding this comment.
I see that you use the variable in Next.js, but then why not use it in Angular SSR?
There was a problem hiding this comment.
I have no idea how to use env vars in angular. If you do, welcoming a PR!
There was a problem hiding this comment.
process.env doesn't work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.