Skip to content

Add basic apphosting.yaml in next.js and angular starter templates. #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Add basic apphosting.yaml in next.js and angular starter templates. #255

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49bf38a
Add basic apphosting.yaml in next.js and angular starter templates.
taeold Sep 12, 2024
ffa5dc3
Use default values as example.
taeold Sep 16, 2024
ba2ffa8
Merge branch 'main' into dl-init-apphosting
taeold Sep 16, 2024
2b46ea7
Merge branch 'main' into dl-init-apphosting
taeold Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions starters/angular/basic/apphosting.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Settings for Backend (on Cloud Run).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a header explaining the use of environment-specific apphosting.yaml overrides?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd rather point the users to public doc so we don't have 2 separate places to track documentations on how to use env specific overrides.

# See https://firebase.google.com/docs/app-hosting/configure#cloud-run.
runConfig:
minInstances: 0
# maxInstances: 100
# concurrency: 80
# cpu: 1
# memoryMiB: 512

# Environment variables and secrets.
# env:
# Configure environment variables.
# See https://firebase.google.com/docs/app-hosting/configure#user-defined-environment.
# - variable: MESSAGE
# value: Hello world!
# availability:
# - BUILD
# - RUNTIME

# Configure secrets
# See https://firebase.google.com/docs/app-hosting/configure#secret-parameters
# - variable: API_KEY
# secret: myApiKeySecret
23 changes: 23 additions & 0 deletions starters/nextjs/basic/apphosting.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Settings for Backend (on Cloud Run).
# See https://firebase.google.com/docs/app-hosting/configure#cloud-run.
runConfig:
minInstances: 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does Angular comment out all values but Nex.tjs does not?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you use the variable in Next.js, but then why not use it in Angular SSR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to use env vars in angular. If you do, welcoming a PR!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process.env doesn't work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

# maxInstances: 100
# concurrency: 80
# cpu: 1
# memoryMiB: 512

# Environment variables and secrets.
env:
# Configure environment variables.
# See https://firebase.google.com/docs/app-hosting/configure#user-defined-environment.
- variable: MESSAGE
value: Hello world!
availability:
- BUILD
- RUNTIME

# Configure secrets
# See https://firebase.google.com/docs/app-hosting/configure#secret-parameters
# - variable: API_KEY
# secret: myApiKeySecret
2 changes: 2 additions & 0 deletions starters/nextjs/basic/src/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import Link from "next/link";

export default function Home() {
const message = process.env["MESSAGE"] || "Hello!";
return (
<main className="content">
<h1 className="heading">Next.js on Firebase App Hosting</h1>
<p>{message}</p>

<section className="features">
<article className="card">
Expand Down