Refine and clean the Turbo + Angular JSON manifest output #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request aims to clean up the build manifest from a Turbo+Angular build by removing web:build: prefixes. The approach of using a regex replacement is sound, but the current implementation has a potential flaw that could lead to data corruption. I've suggested a more robust method to ensure that prefixes are removed safely without the risk of altering JSON string values.
sjjj986
changed the title
sjjj986
changed the title
sjjj986
requested review from
Yuangwang,
jamesdaniels,
annajowang,
blidd-google and
taeold
as code owners
Yuangwang
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where Turbo builds, when used with Angular, introduce extraneous "web:build:" prefixes into the raw JSON manifest output. This PR strips these undesired prefixes, ensuring the Angular manifest get extracted in a proper format.
This PR also bumps the angular adapter and the common folder versions. With the angular manifest parsing fix and the monorepo args split fix, the angular + turbo will be fixed.