Skip to content

v12.8.0#5

Merged
Ryosuke-Asano merged 1 commit intomainfrom
web-store
Dec 6, 2025
Merged

v12.8.0#5
Ryosuke-Asano merged 1 commit intomainfrom
web-store

Conversation

@Ryosuke-Asano
Copy link
Member

…on experiment in experiments.json

Copilot AI review requested due to automatic review settings December 6, 2025 06:15
@Ryosuke-Asano Ryosuke-Asano merged commit 30a554a into main Dec 6, 2025
2 checks passed
@gemini-code-assist
Copy link

Summary of Changes

Hello @surapunoyousei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the experiments.json file to reconfigure an existing experiment slot. The change introduces a new feature flag for enabling Chrome Web Store extension installations, adjusting its initial rollout percentage and providing a descriptive name for the enabled variant.

Highlights

  • Experiment Reconfiguration: An existing experiment entry in experiments.json has been reconfigured, changing its focus from 'Workspace Archive & Restore' to 'Chrome Web Store extension installation'.
  • New Experiment ID and Description: The experiment ID has been updated from workspace_archive to chrome_web_store_install, along with a new description reflecting the change to 'Enable installation of Chrome Web Store extensions'.
  • Rollout Percentage Adjustment: The rollout percentage for the newly configured experiment has been set to 10%.
  • Variant Naming: A name field with the value 'Enabled' has been added to the experiment's variant configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the workspace_archive experiment with a new chrome_web_store_install experiment in the experiments configuration. The new experiment enables installation of Chrome Web Store extensions with a gradual rollout strategy starting at 10%.

Key changes:

  • Replaced the fully rolled out (100%) workspace_archive experiment with a new chrome_web_store_install experiment
  • Set rollout to 10% for gradual deployment of the Chrome Web Store installation feature
  • Added a "name" field to the experiment variant for improved clarity

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"variants": [
{
"id": "enabled",
"name": "Enabled",
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variant now includes a "name" field ("Enabled") which is inconsistent with other experiments in the file. The "pwa_taskbar_integration_linux" experiment (lines 18-31) doesn't have a "name" field in its variant. Either add the "name" field to all experiment variants for consistency, or remove it from this one.

Suggested change
"name": "Enabled",

Copilot uses AI. Check for mistakes.
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the experiments configuration file, replacing an existing experiment with a new one for 'chrome_web_store_install'. My review focuses on improving the experimental design. I have provided a suggestion to introduce a dedicated control group, which will allow for a more robust and accurate analysis of the feature's impact.

Comment on lines 10 to 16
"variants": [
{
"id": "enabled",
"name": "Enabled",
"weight": 100
}
]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current experiment configuration sets a 10% rollout with a single 'enabled' variant at 100% weight. While this is suitable for a simple staged rollout, it lacks a dedicated control group within the experiment population. For more reliable data analysis and to accurately measure the feature's impact against a baseline, it's a best practice to include a control group.

By splitting the 10% population into a treatment group and a control group (e.g., 50/50 split), you can create two comparable groups of users, which helps isolate the feature's effects from other variables and provides more trustworthy results.

            "variants": [
                {
                    "id": "enabled",
                    "name": "Enabled",
                    "weight": 50
                },
                {
                    "id": "control",
                    "name": "Control",
                    "weight": 50
                }
            ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant