Skip to content

v12.8.0 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ryosuke-Asano merged 1 commit into from
Dec 6, 2025
Merged

v12.8.0 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions experiments/experiments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
{
"experiments": [
{
"id": "workspace_archive",
"salt": "workspace_archive_v1_2025",
"description": "Enable Workspace Archive & Restore feature",
"rollout": 100,
"id": "chrome_web_store_install",
"salt": "chrome_web_store_install_v1_2025",
"description": "Enable installation of Chrome Web Store extensions",
"rollout": 10,
"start": "2025-01-01",
"end": "2026-12-31",
"variants": [
{
"id": "enabled",
"name": "Enabled",
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variant now includes a "name" field ("Enabled") which is inconsistent with other experiments in the file. The "pwa_taskbar_integration_linux" experiment (lines 18-31) doesn't have a "name" field in its variant. Either add the "name" field to all experiment variants for consistency, or remove it from this one.

Suggested change
"name": "Enabled",

Copilot uses AI. Check for mistakes.
"weight": 100
}
]
Comment on lines 10 to 16
Copy link

@gemini-code-assist gemini-code-assist bot Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current experiment configuration sets a 10% rollout with a single 'enabled' variant at 100% weight. While this is suitable for a simple staged rollout, it lacks a dedicated control group within the experiment population. For more reliable data analysis and to accurately measure the feature's impact against a baseline, it's a best practice to include a control group.

By splitting the 10% population into a treatment group and a control group (e.g., 50/50 split), you can create two comparable groups of users, which helps isolate the feature's effects from other variables and provides more trustworthy results.

            "variants": [
                {
                    "id": "enabled",
                    "name": "Enabled",
                    "weight": 50
                },
                {
                    "id": "control",
                    "name": "Control",
                    "weight": 50
                }
            ]

Expand Down