Fix startup localization issues #2881

Yusyuriv · 2024-08-10T03:25:29Z

Fixes issue from #2769

Yusyuriv · 2024-08-10T03:26:24Z

Flow.Launcher.Core/Plugin/PluginManager.cs

        public static IEnumerable<PluginPair> GetPluginsForInterface<T>() where T : IFeatures
        {
-            return AllPlugins.Where(p => p.Plugin is T);
+            return AllPlugins?.Where(p => p.Plugin is T) ?? Array.Empty<PluginPair>();


Fixes startup issue when built by Visual Studio

Yusyuriv · 2024-08-10T03:27:14Z

Flow.Launcher.Core/Resource/Internationalization.cs


        private void LoadDefaultLanguage()
        {
+            RemoveOldLanguageFiles();


Removes language files loaded before any plugins were loaded. Prevents the language Flow started in from overwriting English if the user switches back to English

coderabbitai · 2024-08-10T03:27:58Z

Walkthrough

The recent changes enhance the robustness and functionality of the PluginManager and Internationalization classes. The GetPluginsForInterface<T>() method now safely handles null references, ensuring it always returns a valid collection. Additionally, the LoadDefaultLanguage method has been updated to remove outdated language files before loading defaults, improving language management. These modifications contribute to greater reliability and efficiency in the application.

Changes

Files	Change Summary
`Flow.Launcher.Core/Plugin/PluginManager.cs`, `Flow.Launcher.Core/Resource/Internationalization.cs`	Improved null safety in `GetPluginsForInterface<T>()` to return an empty array when no plugins are found; added `RemoveOldLanguageFiles()` in `LoadDefaultLanguage` to clear outdated language files before loading.

Poem

🐇 In the code where bunnies hop,
Plugins now won't let you drop.
Old files gone, new paths to find,
Language flows, all aligned.
Bugs be gone, let joy arise,
Hoppy changes, what a surprise! 🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gitstream-cm · 2024-08-10T03:28:56Z

🥷 Code experts: VictoriousRaptor

Yusyuriv has most 👩‍💻 activity in the files.
VictoriousRaptor has most 🧠 knowledge in the files.

See details

Flow.Launcher.Core/Plugin/PluginManager.cs

Activity based on git-commit:

	Yusyuriv
AUG
JUL
JUN	21 additions & 11 deletions
MAY
APR
MAR

Knowledge based on git-blame:
VictoriousRaptor: 28%

Flow.Launcher.Core/Resource/Internationalization.cs

Activity based on git-commit:

	Yusyuriv
AUG
JUL
JUN	9 additions & 8 deletions
MAY
APR
MAR

Knowledge based on git-blame:
VictoriousRaptor: 6%

To learn more about /:\ gitStream - Visit our Docs

gitstream-cm · 2024-08-10T03:29:06Z

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Flow.Launcher.Core/Resource/Internationalization.cs

Flow.Launcher.Core/Plugin/PluginManager.cs

github-actions · 2024-08-11T10:57:23Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Fix startup localization issues

81e5eaf

Yusyuriv added bug Something isn't working Dev branch only An issue or fix for the Dev branch build labels Aug 10, 2024

Yusyuriv self-assigned this Aug 10, 2024

github-actions bot added this to the 1.19.0 milestone Aug 10, 2024

Yusyuriv commented Aug 10, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Yusyuriv commented Aug 10, 2024

View reviewed changes

Yusyuriv marked this pull request as ready for review August 10, 2024 03:27

gitstream-cm bot added the 1 min review label Aug 10, 2024

jjw24 reviewed Aug 11, 2024

View reviewed changes

Flow.Launcher.Core/Resource/Internationalization.cs Show resolved Hide resolved

add comment

7e3690f

This comment has been minimized.

Sign in to view

jjw24 reviewed Aug 11, 2024

View reviewed changes

Flow.Launcher.Core/Plugin/PluginManager.cs Show resolved Hide resolved

add comment

89e430f

jjw24 approved these changes Aug 11, 2024

View reviewed changes

jjw24 removed the bug Something isn't working label Aug 11, 2024

prlabeler bot added the bug Something isn't working label Aug 11, 2024

jjw24 removed the bug Something isn't working label Aug 11, 2024

jjw24 enabled auto-merge August 11, 2024 10:58

jjw24 merged commit a075205 into dev Aug 11, 2024

jjw24 deleted the fix-startup-localization-issues branch August 11, 2024 11:09

jjw24 removed the 1 min review label Aug 11, 2024

coderabbitai bot mentioned this pull request Aug 13, 2024

Release 1.19.0 | Plugin 4.4.0 #2887

Merged

coderabbitai bot mentioned this pull request Sep 15, 2024

Improve plugin loading performance #2973

Closed

coderabbitai bot mentioned this pull request Jan 2, 2025

Add System Language Item #3161

Merged

coderabbitai bot mentioned this pull request Jan 24, 2025

Improve uninstaller check function #3197

Merged

coderabbitai bot mentioned this pull request Feb 28, 2025

Dependency Injection Code Quality #3276

Closed

1 task

coderabbitai bot mentioned this pull request Jul 3, 2025

Check plugin modified state for more lists and improve code quality #3795

Merged

coderabbitai bot mentioned this pull request Jul 20, 2025

Initialize language earlier for portable clean up and plugin initialization #3850

Merged

coderabbitai bot mentioned this pull request Sep 18, 2025

Remove old dictionaries references to fix possible memory leak #3990

Merged

Uh oh!

Fix startup localization issues #2881

Fix startup localization issues #2881

Uh oh!

Conversation

Yusyuriv commented Aug 10, 2024 • edited by jjw24 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yusyuriv Aug 10, 2024

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Yusyuriv Aug 10, 2024

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented Aug 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

gitstream-cm bot commented Aug 10, 2024

Uh oh!

gitstream-cm bot commented Aug 10, 2024

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

github-actions bot commented Aug 11, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Yusyuriv commented Aug 10, 2024 •

edited by jjw24

Loading

coderabbitai bot commented Aug 10, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)