Skip to content

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Apr 19, 2025

  • seach to search
  • "This theme supports two(light/dark) modes." to "This theme supports two (light/dark) modes."
  • "Show badges for query results where supported" to "For supported plugins, badges are displayed to help distinguish them more easily."
  • Remove "Show badges for global query results only" (duplicated with title)
  • "Disable this program from displaying" to "Hide"

@onesounds onesounds self-assigned this Apr 19, 2025
@prlabeler prlabeler bot added the bug Something isn't working label Apr 19, 2025

This comment has been minimized.

Copy link

gitstream-cm bot commented Apr 19, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Copy link
Contributor

coderabbitai bot commented Apr 19, 2025

📝 Walkthrough

Walkthrough

This update corrects typographical errors in four string resource entries within the English language files. The word "seach" was corrected to "search" in both the main label and its tooltip for the plugin search delay time setting. A space was inserted between "two" and the parenthetical "(light/dark)" in the tooltip for the dark mode type setting. The tooltip for showing badges globally was removed, and the tooltip for showing badges was reworded to a more descriptive sentence. Additionally, the label for disabling a program display was shortened from "Disable this program from displaying" to "Hide." No code logic, structure, or exported entities were modified.

Changes

File(s) Change Summary
Flow.Launcher/Languages/en.xaml Fixed typos in string resources: "seach" → "search" for plugin search delay time label and tooltip; added space between "two" and "(light/dark)" in TypeIsDarkToolTip; reworded showBadgesToolTip to a descriptive sentence; removed showBadgesGlobalOnlyToolTip.
Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml Removed subtitle attribute bound to showBadgesGlobalOnlyToolTip from the card titled showBadgesGlobalOnly.
Plugins/Flow.Launcher.Plugin.Program/Languages/en.xaml Changed string resource value from "Disable this program from displaying" to shorter label "Hide" for flowlauncher_plugin_program_disable_program.

Possibly related PRs

  • New Crowdin updates #2795: Fixes typographical errors in English string resources including the tooltip for "TypeIsDarkToolTip"; updates translations of the same tooltip and other strings in multiple languages.

Suggested labels

kind/i18n

Suggested reviewers

  • Jack251970

Poem

A bunny hopped through lines of code,
And found a typo on the road.
"Seach" became "search"—oh what a delight!
A space appeared to make things right.
“Disable” shortened to “Hide” with care,
Tooltips polished everywhere! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09f04bc and 31f2866.

📒 Files selected for processing (2)
  • Flow.Launcher/Languages/en.xaml (3 hunks)
  • Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • Flow.Launcher/Languages/en.xaml
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: gitStream.cm
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@onesounds onesounds added kind/i18n and removed bug Something isn't working labels Apr 20, 2025
@Jack251970 Jack251970 requested a review from Copilot April 20, 2025 01:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • Flow.Launcher/Languages/en.xaml: Language not supported
  • Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml: Language not supported
  • Plugins/Flow.Launcher.Plugin.Program/Languages/en.xaml: Language not supported

@onesounds onesounds merged commit 09723c2 into Flow-Launcher:dev Apr 20, 2025
8 checks passed
@jjw24 jjw24 added Dev branch only An issue or fix for the Dev branch build and removed 1 min review labels Apr 21, 2025
@jjw24 jjw24 added this to the 1.20.0 milestone Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dev branch only An issue or fix for the Dev branch build kind/i18n

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants