Skip to content

Conversation

Jack251970
Copy link
Member

Fix startup flicker for Win 11 theme

Remove await _theme.RefreshFrameAsync(); in main window loaded event because in App.xaml.cs, it is already called in Ioc.Default.GetRequiredService<Theme>().ChangeTheme();

Resolve #3514.

@Jack251970 Jack251970 added the Dev branch only An issue or fix for the Dev branch build label May 9, 2025
@prlabeler prlabeler bot added the bug Something isn't working label May 9, 2025
@Jack251970 Jack251970 requested a review from Copilot May 9, 2025 08:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a startup flicker issue on Windows 11 by removing a duplicate theme refresh call, thereby improving the startup visual consistency.

  • Removed the duplicate call to RefreshFrameAsync in MainWindow.xaml.cs.
  • Updated a comment in App.xaml.cs to better reflect theme initialization for the main window.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Flow.Launcher/MainWindow.xaml.cs Removed the redundant await _theme.RefreshFrameAsync() call.
Flow.Launcher/App.xaml.cs Updated comment to clarify main window theme initialization.

@Jack251970 Jack251970 removed the bug Something isn't working label May 9, 2025
@Jack251970 Jack251970 added this to the 1.20.0 milestone May 9, 2025
Copy link

github-actions bot commented May 9, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 24
⚠️ non-alpha-in-dictionary 19

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link

gitstream-cm bot commented May 9, 2025

🥷 Code experts: no user but you matched threshold 10

Jack251970, onesounds have most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher/App.xaml.cs

Activity based on git-commit:

Jack251970 onesounds
MAY 7 additions & 2 deletions
APR 73 additions & 40 deletions 3 additions & 0 deletions
MAR 168 additions & 94 deletions
FEB 79 additions & 40 deletions
JAN 86 additions & 66 deletions
DEC

Knowledge based on git-blame:
Jack251970: 67%

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

Jack251970 onesounds
MAY 19 additions & 11 deletions
APR 69 additions & 45 deletions 5 additions & 1 deletions
MAR 1141 additions & 1076 deletions 327 additions & 141 deletions
FEB 1 additions & 1 deletions 8 additions & 4 deletions
JAN
DEC 5 additions & 10 deletions

Knowledge based on git-blame:
Jack251970: 65%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented May 9, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@Jack251970 Jack251970 enabled auto-merge May 9, 2025 08:01
Copy link
Contributor

coderabbitai bot commented May 9, 2025

📝 Walkthrough

Walkthrough

A comment in the theme initialization section was revised for clarity, and the asynchronous call to refresh the theme frame during the main window load sequence was removed. No changes were made to public APIs or the overall logic flow, apart from omitting the theme frame refresh.

Changes

File(s) Change Summary
Flow.Launcher/App.xaml.cs Updated a comment describing the theme initialization; no functional or logic changes.
Flow.Launcher/MainWindow.xaml.cs Removed the awaited call to _theme.RefreshFrameAsync() in the OnLoaded handler; adjusted sequence.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant MainWindow
    participant Theme

    App->>Theme: ChangeTheme()
    App->>MainWindow: Initialize MainWindow
    MainWindow->>MainWindow: UpdatePosition()
    %% Removed: MainWindow->>Theme: RefreshFrameAsync()
    MainWindow->>MainWindow: SetupResizeMode()
Loading

Assessment against linked issues

Objective Addressed Explanation
Prevent search bar flicker on startup (#3514)

Suggested reviewers

  • onesounds

Poem

A window once flickered, now calm as can be,
With a tweak to the theme and a frame set free.
No more async delays, just a seamless display,
The search bar now shines in a flickerless way.
🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d2f7de and 29f94d6.

📒 Files selected for processing (2)
  • Flow.Launcher/App.xaml.cs (1 hunks)
  • Flow.Launcher/MainWindow.xaml.cs (0 hunks)
💤 Files with no reviewable changes (1)
  • Flow.Launcher/MainWindow.xaml.cs
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: gitStream workflow automation
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
🔇 Additional comments (1)
Flow.Launcher/App.xaml.cs (1)

206-206: Streamlined comment improves clarity
The revised comment succinctly conveys the intent behind the ChangeTheme() call without redundant detail, enhancing readability.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jack251970 Jack251970 merged commit 2fdab61 into dev May 10, 2025
14 checks passed
@Jack251970 Jack251970 deleted the startup_flicker branch May 10, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dev branch only An issue or fix for the Dev branch build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev branch- search bar flickers once when started up

2 participants