-
-
Notifications
You must be signed in to change notification settings - Fork 448
Fix startup flicker #3521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix startup flicker #3521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a startup flicker issue on Windows 11 by removing a duplicate theme refresh call, thereby improving the startup visual consistency.
- Removed the duplicate call to RefreshFrameAsync in MainWindow.xaml.cs.
- Updated a comment in App.xaml.cs to better reflect theme initialization for the main window.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
Flow.Launcher/MainWindow.xaml.cs | Removed the redundant await _theme.RefreshFrameAsync() call. |
Flow.Launcher/App.xaml.cs | Updated comment to clarify main window theme initialization. |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. Forbidden patterns 🙅 (1)In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves. These forbidden patterns matched content: s.b. workaround(s)
If the flagged items are 🤯 false positivesIf items relate to a ...
|
🥷 Code experts: no user but you matched threshold 10 Jack251970, onesounds have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 WalkthroughWalkthroughA comment in the theme initialization section was revised for clarity, and the asynchronous call to refresh the theme frame during the main window load sequence was removed. No changes were made to public APIs or the overall logic flow, apart from omitting the theme frame refresh. Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant MainWindow
participant Theme
App->>Theme: ChangeTheme()
App->>MainWindow: Initialize MainWindow
MainWindow->>MainWindow: UpdatePosition()
%% Removed: MainWindow->>Theme: RefreshFrameAsync()
MainWindow->>MainWindow: SetupResizeMode()
Assessment against linked issues
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fix startup flicker for Win 11 theme
Remove
await _theme.RefreshFrameAsync();
in main window loaded event because inApp.xaml.cs
, it is already called inIoc.Default.GetRequiredService<Theme>().ChangeTheme();
Resolve #3514.