Fix system ColorScheme update handling

[onesounds]

Fix system ColorScheme update handling

Summary

• Fixed an issue where changes to the system ColorScheme (e.g., via AutoDarkMode or OS settings) were not properly reflected in Flow's window background color.

Steps to Reproduce

• In Dev mode, select a theme that includes both Light and Dark modes (e.g., win11light).
• Set the ColorScheme option to Follow system setting.
• Change the OS ColorScheme (e.g., switch from Light to Dark).
• Observe that, although the system is in Dark mode, the window background remains white.

Cause

• The window background color is updated during the RefreshFrame process.
• Due to changes in the timing of RefreshFrame, the background color update was no longer triggered properly.

Solution

• Since ModernWpf already listens for system ColorScheme changes, we subscribe to its event.
• When the system ColorScheme change event is received, we explicitly call RefreshFrame once to apply the correct background color.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

"""

Walkthrough

The change introduces an event handler in the main window to listen for application theme changes. When the theme changes, the UI frame is refreshed asynchronously by invoking a specific method. This ensures the interface responds dynamically to theme updates without altering other logic.

Changes

File(s)	Change Summary
Flow.Launcher/MainWindow.xaml.cs	Subscribed to the application theme change event; added an event handler to refresh the UI frame asynchronously when the theme changes; unsubscribed from the event in Dispose to prevent memory leaks.

Sequence Diagram(s)

sequenceDiagram
    participant ThemeManager
    participant MainWindow
    participant Theme

    ThemeManager->>MainWindow: ActualApplicationThemeChanged event
    MainWindow->>MainWindow: ThemeManager_ActualApplicationThemeChanged()
    MainWindow->>Theme: RefreshFrameAsync()

Loading

Possibly related PRs

• Fix startup flicker #3521: Both PRs adjust when and how _theme.RefreshFrameAsync() is called in MainWindow.xaml.cs, focusing on the timing of theme refreshes in response to theme changes.

Suggested labels

enhancement, kind/ux

Suggested reviewers

• Jack251970

Poem

A theme has changed, the night or day,
The window listens, leaps to play.
With every shift, a frame anew,
The UI sparkles, fresh and true.
Hopping along, we keep in sync,
A rabbit’s touch—blink, blink, blink! 🐇✨
"""

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e51bdc and f29ccb3.

📒 Files selected for processing (1)

• Flow.Launcher/MainWindow.xaml.cs (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Flow.Launcher/MainWindow.xaml.cs

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: build

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1ba81e and f0aa285.

📒 Files selected for processing (1)

• Flow.Launcher/MainWindow.xaml.cs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: build

🔇 Additional comments (1)

Flow.Launcher/MainWindow.xaml.cs (1)

92-92: Subscription to theme change event looks good.

The event subscription to ActualApplicationThemeChanged will allow the app to detect when the system color scheme changes, addressing the issue described in the PR.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	24
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.