Fix false failing spell check rules #3745
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🥷 Code experts: VictoriousRaptor VictoriousRaptor has most 🧠 knowledge in the files. See details
Knowledge based on git-blame:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 WalkthroughWalkthroughThe updates involve modifying the custom spelling dictionary and pattern files used for spell checking in a GitHub Action. Several specific terms and names were removed from the dictionary file and added to the patterns file. Both files received new explanatory comments at the top. Changes
Suggested labels
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/actions/spelling/patterns.txt (1)
2-2: Clarifying comment enhancement
The new top‐level comment helps readers understand the file's purpose. Consider extending it to explicitly mention support for Unicode (e.g., accented letters) and special characters to reflect entries like “Tiếng Việt” and “čeština.”
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/actions/spelling/expect.txt(1 hunks).github/actions/spelling/patterns.txt(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: gitStream workflow automation
- GitHub Check: gitStream.cm
- GitHub Check: build
🔇 Additional comments (1)
.github/actions/spelling/expect.txt (1)
1-2: Approve clarifying comment addition
The updated header accurately describes the file’s role in listing proper nouns and product names outside a standard dictionary.
|
|
||
| \bjjw24\b | ||
| \bappref-ms\b | ||
| \bTobiasSekan\b | ||
| \bJsonRPC\b | ||
| \bJsonRPCV2\b | ||
| \bTiếng Việt\b | ||
| \bPortuguês (Brasil)\b | ||
| \bčeština\b | ||
| \bPortuguês\b |
There was a problem hiding this comment.
Escape literal parentheses in patterns
The pattern \bPortuguês (Brasil)\b uses unescaped parentheses, so it matches “Português Brasil” rather than “Português (Brasil)”. This will fail to exclude the original term.
Apply this diff to escape the parentheses:
-\bPortuguês (Brasil)\b
+\bPortuguês \(Brasil\)\b📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| \bjjw24\b | |
| \bappref-ms\b | |
| \bTobiasSekan\b | |
| \bJsonRPC\b | |
| \bJsonRPCV2\b | |
| \bTiếng Việt\b | |
| \bPortuguês (Brasil)\b | |
| \bčeština\b | |
| \bPortuguês\b | |
| \bjjw24\b | |
| \bappref-ms\b | |
| \bTobiasSekan\b | |
| \bJsonRPC\b | |
| \bJsonRPCV2\b | |
| \bTiếng Việt\b | |
| \bPortuguês \(Brasil\)\b | |
| \bčeština\b | |
| \bPortuguês\b |
🤖 Prompt for AI Agents
In .github/actions/spelling/patterns.txt around lines 126 to 135, the pattern
\bPortuguês (Brasil)\b uses unescaped parentheses, causing it to match
"Português Brasil" instead of "Português (Brasil)". Fix this by escaping the
parentheses in the pattern, changing it to \bPortuguês \(Brasil\)\b to correctly
match the literal parentheses.
2 participants
Fix false failing spell check rules.
patterns.txt use Cases:
expect.txt use cases: