Change double pinyin panel design

[Jack251970]

Change double pinyin panel design

Reason for this changing:

• Originally, we use visibility to organize the relationship of these options, but it looks little strange since all elements in setting window do not use this in its design.
• Now I change it to expand card & card design to make it look more unified with others.

Follows on from #2427

[gitstream-cm]

🥷 Code experts: onesounds, VictoriousRaptor

onesounds, Jack251970 have most 👩‍💻 activity in the files.
onesounds, Jack251970 have most 🧠 knowledge in the files.

See details

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml

Activity based on git-commit:

	onesounds	Jack251970
JUL
JUN	50 additions & 36 deletions	26 additions & 14 deletions
MAY		62 additions & 11 deletions
APR	130 additions & 69 deletions	11 additions & 8 deletions
MAR	43 additions & 62 deletions	44 additions & 20 deletions
FEB		1 additions & 1 deletions

Knowledge based on git-blame:
onesounds: 56%
Jack251970: 17%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

The update restructures the Pinyin-related settings layout in the general settings pane's XAML file. It removes the grouped card structure, introduces a nested card and ex-card arrangement, and eliminates visibility bindings, resulting in always-visible controls for Pinyin toggles and schema selection, but with a new visual grouping.

Changes

File(s)	Summary of Changes
Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml	Refactored Pinyin settings UI: replaced grouped cards with nested card/ex-card layout, removed visibility bindings

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingsPaneGeneral (XAML)
    User->>SettingsPaneGeneral (XAML): Opens General Settings
    SettingsPaneGeneral (XAML)->>SettingsPaneGeneral (XAML): Displays Pinyin settings (all controls always visible, new grouping)
    User->>SettingsPaneGeneral (XAML): Toggles Pinyin/Double Pinyin, selects schema

Loading

Possibly related PRs

• Double pinyin query #2427: Implements Double Pinyin functionality and settings, which are directly reflected in the UI changes of this PR.

Suggested labels

enhancement

Suggested reviewers

• jjw24
• onesounds

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42b2fd1 and 05e01ab.

📒 Files selected for processing (1)

• Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: gitStream workflow automation
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: build
• GitHub Check: Check Spelling

🔇 Additional comments (1)

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml (1)

374-384: Good consistency improvement with the new Card layout.

The standalone Card structure aligns well with other settings in the file and improves visual consistency.

[VictoriousRaptor]

Do we need some rework on this design since if double pinyin is true then use pinyin must be true as well?