Updates for VTK9 and PETSC 3.15-24 #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build, some tests fail
It appears using the rules Makefile - which provide getlinklibs and getincludedirs targets - is not consistent between different versions. Now mimicking these by printing combinations of export variables from "variables" Makefile Dropping older version of petsc makefile.
stephankramer
force-pushed
the
fix-petsc-makefile
branch
8 times, most recently
from
c3c1dae to
ff404b4
Compare
It seems to change answers, although I don't understand why.
This is the oldest petsc version I care about (Jammy)
Let's tackle this in a separate PR as I think switching breaks a number of tests - most of these we might care about but we should probably look a bit closer before merging.
for more information, see https://pre-commit.ci
stephankramer
changed the title
Includes Build, short, medium and unit tests
Patol75
reviewed
Oct 30, 2025
Contributor
Patol75
left a comment
Patol75
left a comment
There was a problem hiding this comment.
Thank you! Changes look good, and they come with successful CI runs. You probably need to modify the expected CI checks in the repository settings, but apart from that, the work is pretty much done.
Changes in 4fb595c are needed but break Jammy. TODO: switch over to build manual on Noble, not Jammy
With gfortran 13 (noble) despite the cleverness our is_nan check is beaten by the compiler optimisation.
Needs some more work.
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines a few updates now: