Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4fb595c
Fluidity Ubuntu 24.04 build. Manual not working. libexpat/VTK not wor…
dsroberts Jul 15, 2025
d21285c
Fix VTK_INSTALL_PREFIX
dsroberts Jul 15, 2025
1bf62a9
Move PETSC_NULL definition to petsc_legacy.h
dsroberts Jul 15, 2025
89fdd66
Noble dockerfiles. Unit tests pass on Noble (except one), docs don't …
dsroberts Jul 16, 2025
310b912
Use petsc variables Makefile only.
stephankramer Aug 19, 2024
0ad4d09
PETSc API changes up to 3.24
stephankramer Oct 24, 2025
7ff5e8c
Drop bionic and focal from CI
stephankramer Oct 24, 2025
ff404b4
Various fixes 3.23/24
stephankramer Oct 27, 2025
2dd2b2d
Merge remote-tracking branch 'dale/dsroberts/noble' into fix-petsc-ma…
stephankramer Oct 29, 2025
bbe7ea0
Undo this "fix"
stephankramer Oct 29, 2025
5a72c67
New petsc makefile also seems to work for 3.15
stephankramer Oct 29, 2025
df0b9a3
Revert to (very!) old version of gmsh
stephankramer Oct 29, 2025
7368aab
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 29, 2025
b830f18
Revert manual changes from 4fb595cdfd604dc8827909aa0701a4a306e717cc
stephankramer Oct 29, 2025
f934e68
Extend CI to Noble.
stephankramer Oct 29, 2025
f6cc6d6
Temp. disable manual build on Noble
stephankramer Oct 30, 2025
aefca5f
Workaround
stephankramer Oct 30, 2025
258b877
Oops
stephankramer Oct 30, 2025
937327b
Fix manual build on Noble
stephankramer Oct 30, 2025
be613d9
Compile unittest_tools module without fast math
stephankramer Oct 30, 2025
8c72b79
Switch off Noble short and medium tests for now
stephankramer Oct 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 10 additions & 28 deletions .github/workflows/ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,18 @@ jobs:
strategy:
fail-fast: false
matrix:
name: [ "Build Bionic", "Build Focal", "Build Jammy", "Build Jammy OMP" ]
name: [ "Build Jammy", "Build Jammy OMP", "Build Noble" ]
include:

- name: "Build Bionic"
release: bionic

- name: "Build Focal"
release: focal

- name: "Build Jammy"
release: jammy

- name: "Build Jammy OMP"
release: jammy-omp

- name: "Build Noble"
release: noble

steps:

- name: Check Out Repo
Expand Down Expand Up @@ -62,29 +59,9 @@ jobs:
strategy:
fail-fast: false
matrix:
name: [ "Short Bionic", "Unit Focal", "Short Focal", "Medium Focal", "Unit Jammy", "Short Jammy", "Medium Jammy" ]
name: [ "Unit Jammy", "Short Jammy", "Medium Jammy", "Unit Noble" ]
include:

- name: "Short Bionic"
release: bionic
command: "make THREADS=2 test"
output: "test_results.xml"

- name: "Unit Focal"
release: focal
command: "make unittest"
output: "test_results_unittests.xml"

- name: "Short Focal"
release: focal
command: "make THREADS=2 test"
output: "test_results.xml"

- name: "Medium Focal"
release: focal
command: "make THREADS=2 mediumtest"
output: "test_results_medium.xml"

- name: "Unit Jammy"
release: jammy
command: "make unittest"
Expand All @@ -100,6 +77,11 @@ jobs:
command: "make THREADS=2 mediumtest"
output: "test_results_medium.xml"

- name: "Unit Noble"
release: noble
command: "make unittest"
output: "test_results_unittests.xml"

steps:

- name: ${{ matrix.name }} Testing
Expand Down
7 changes: 5 additions & 2 deletions aclocal.m4
Original file line number Diff line number Diff line change
Expand Up @@ -419,11 +419,11 @@ if test "x$PETSC_DIR" == "x"; then
fi
AC_MSG_NOTICE([Using PETSC_DIR=$PETSC_DIR])

PETSC_LINK_LIBS=`make -s -f petsc_makefile_old getlinklibs 2> /dev/null || make -s -f petsc_makefile getlinklibs`
PETSC_LINK_LIBS=`make -s -f petsc_makefile getlinklibs`
LIBS="$PETSC_LINK_LIBS $LIBS"

# need to add -I$PWD/include/ to what we get from petsc, so we can use our own petsc_legacy.h wrapper
PETSC_INCLUDE_FLAGS=`make -s -f petsc_makefile_old getincludedirs 2> /dev/null || make -s -f petsc_makefile getincludedirs`
PETSC_INCLUDE_FLAGS=`make -s -f petsc_makefile getincludedirs`
CPPFLAGS="$CPPFLAGS $PETSC_INCLUDE_FLAGS -I$PWD/include/"
FCFLAGS="$FCFLAGS $PETSC_INCLUDE_FLAGS -I$PWD/include/"

Expand Down Expand Up @@ -562,6 +562,9 @@ AC_LANG_RESTORE


AC_DEFINE(HAVE_PETSC,1,[Define if you have the PETSc library.])
if test "0$PETSC_VERSION_MAJOR" -ge 3 -a "0$PETSC_VERSION_MINOR" -lt 19; then
AC_DEFINE(PETSC_NULLPTR,PETSC_NULL,[Name of PETSc's null pointer type])
fi

])dnl ACX_PETSc

Expand Down
2 changes: 1 addition & 1 deletion assemble/tests/test_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ int main(int argc, char **argv)
}
#endif
#ifdef HAVE_PETSC
PetscInitialize(&argc, &argv, NULL, PETSC_NULL);
PetscInitialize(&argc, &argv, NULL, PETSC_NULLPTR);
PetscInitializeFortran();
#endif

Expand Down
2 changes: 1 addition & 1 deletion climatology/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ LINKER = $(CXX)
CXXFLAGS = -I../include @CXXFLAGS@ @CPPFLAGS@

LFLAGS = @LDFLAGS@
LIBS = -L../lib/ @LIBS@ @FLIBS@
LIBS = -L../lib/ @LIBS@ @FLIBS@ @LAPACK_LIBS@

.SUFFIXES: .cpp .o

Expand Down
Loading
Loading