Skip to content

Conversation

matthew-carroll
Copy link
Contributor

@matthew-carroll matthew-carroll commented Jun 27, 2025

Run golden tests in CI (Resolves #36)

  • Added Dockerfile to use golden_runner Docker runner.
    • TODO: Figure out how to not require a Dockerfile within each project that uses golden_runner
  • Copied the golden matcher with pixel tolerance from super_editor to this package
  • Added tolerance to SingleShot and Gallery but still need to add it to Timeline
  • Fixed a bug where failure images were generated for passing goldens - problem was a missing return statement
  • Fixed a difference between generated screenshots vs compared screenshots. Not entirely sure where the problem was happening, but the solution was to align the content left within the defaultGoldenSceneItemDecorator
  • Regenerated all existing goldens using golden_runner so that CI should pass. One test required an 5px tolerance to pass GitHub's CI.

…on of Flutter's standard matcher, which also allows pixel tolerances (pulled from super_editor).
@matthew-carroll
Copy link
Contributor Author

FYI @angelosilvestre - I'm gonna merge, but feel free to look through the changes/fixes.

We should try to come back ASAP and delete the Dockerfile, but that depends on changes to the golden_runner, which I have yet to publish to Pub.

@matthew-carroll matthew-carroll merged commit 619222d into main Jul 4, 2025
2 checks passed
@matthew-carroll matthew-carroll deleted the 36_add-golden-tests-to-ci branch July 4, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra] - Run tests in CI
1 participant