Skip to content

Added 'Allowed Swipe Direction' property Info #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

pinkeshmars
Copy link
Collaborator

Description

Added Allowed Swipe Direction property Info

Linear ticket and magic word Fixes DEVR-722

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot requested a review from PoojaB26 December 16, 2024 04:55
Copy link
Collaborator

@PoojaB26 PoojaB26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit changes required. Please fix them before merging!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arent we doing light mode images anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we still use light mode images only, but for this case, almost all assets on this page are dark themed. So, to maintain consistency, I used a black one. Whenever in the future we take this for full or partial rewrite, we can update with light mode images.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even for these cases, we could still do light mode images, because we are adding more efforts on our end, like waiting for the rewrite and only then changing completely. Because some of the topics may not go for a rewrite very soon. If we are adding new section to an old topic, or updating a section of a topic, we should still follow what we would have done for a completely new topic.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, it's updated now.

@leighajarett leighajarett merged commit a46b428 into main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants