-
Notifications
You must be signed in to change notification settings - Fork 108
Added 'Allowed Swipe Direction' property Info #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ece6c9f
Added Allowed Swipe Direction property info
pinkeshmars 9f0e753
Update docs/resources/ui/widgets/built-in-widgets/swipeablestack.md
pinkeshmars 055734a
Update image asset
pinkeshmars 28f44f3
Merge branch 'main' into pinkesh/allow-swipe-direction-property
leighajarett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+749 KB
docs/resources/ui/widgets/built-in-widgets/imgs/allowed-swipe-direction.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arent we doing light mode images anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we still use light mode images only, but for this case, almost all assets on this page are dark themed. So, to maintain consistency, I used a black one. Whenever in the future we take this for full or partial rewrite, we can update with light mode images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even for these cases, we could still do light mode images, because we are adding more efforts on our end, like waiting for the rewrite and only then changing completely. Because some of the topics may not go for a rewrite very soon. If we are adding new section to an old topic, or updating a section of a topic, we should still follow what we would have done for a completely new topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, it's updated now.