Conversation
ext
requested review from
MCFK,
Marie-Jakobsson,
NicklasWei,
TMFKse,
atfkassan,
dvitamin,
jameseklund,
jensviklander,
kristinalindstrom and
udenius
as code owners
Artifact sizesArtifact sizes in this build (unchanged artifacts collapsed below).
2 unchanged artifacts
|
Förhandsgranskning 🐛 🔍Dokumentation och exampel applikationer finns att förhandsgranska på: Senast uppdaterad 2026-03-09 09:44 UTC i gh-pages. |
MCFK
approved these changes
Mar 9, 2026
ext
force-pushed
the
refactor/eslint
branch
3 times, most recently
from
3a3860c to
4246a3a
Compare
ext
force-pushed
the
refactor/eslint-batch-2
branch
from
a1bdf87 to
a490bf7
Compare
CHANGELOGNo commits contributing to a release was found, no changelog entries will be added for this Pull Request. If this PR should be included in a release amend the commit message(s) to use:
Read more about the release process (swedish). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hyfsat säker på att allt detta är ok och testerna går igenom så. Men denna är väl den som är mest risky utav dem så om ni ska granska någon utav dem så är det denna som behöver extra ögon.
Men några saker att tänka på:
Number.isNaN()ochisNaN()är inte 100% ekvivalenta men med typescript så är det korrekt och typsäkert, men jag vet ju att kod runt validering framförallt ljuger otroligt mycket om vad det är för datatyper så det är inte omöjligt att det blir något knasigt här. Men testerna går igenom så...[...foo].toReversed()kan ju optimeras tillfoo.toReversed()då hela poängen är att man inte ska behöva göra en kopia själv.