fix: use player thread for player calls #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Added
onTaskRemoved()override to ensure internal calls to the player are done on the player thread. This is a quick fix for what appears to be a bug in media3 implementation (internal calls shouldn't assume the player runs on the main thread).The whole keep player on background thread thing needs to be revisited.
Tests performed
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).