Skip to content

fix: use player thread for player calls #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Nov 5, 2025
Merged

fix: use player thread for player calls #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Fixed player crash when clearing app from recents ([#298])

## [1.5.0] - 2025-10-29
### Changed
Expand Down Expand Up @@ -81,6 +83,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#258]: https://github.com/FossifyOrg/Music-Player/issues/258
[#261]: https://github.com/FossifyOrg/Music-Player/issues/261
[#269]: https://github.com/FossifyOrg/Music-Player/issues/269
[#298]: https://github.com/FossifyOrg/Music-Player/issues/298

[Unreleased]: https://github.com/FossifyOrg/Music-Player/compare/1.5.0...HEAD
[1.5.0]: https://github.com/FossifyOrg/Music-Player/compare/1.4.0...1.5.0
Expand Down
1 change: 0 additions & 1 deletion app/src/main/kotlin/org/fossify/musicplayer/activities/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import org.fossify.musicplayer.playback.CustomCommands
import org.greenrobot.eventbus.EventBus
import org.greenrobot.eventbus.Subscribe
import org.greenrobot.eventbus.ThreadMode
import java.io.File
import java.io.FileOutputStream

class MainActivity : SimpleMusicActivity() {
Expand Down
11 changes: 10 additions & 1 deletion app/src/main/kotlin/org/fossify/musicplayer/playback/PlaybackService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.fossify.musicplayer.playback

import android.content.Intent
import android.os.Handler
import android.os.HandlerThread
import android.os.Looper
Expand Down Expand Up @@ -75,7 +76,9 @@ class PlaybackService : MediaLibraryService(), MediaSessionService.Listener {
}
}

internal fun withPlayer(callback: SimpleMusicPlayer.() -> Unit) = playerHandler.post { callback(player) }
internal fun withPlayer(callback: SimpleMusicPlayer.() -> Unit) {
playerHandler.post { callback(player) }
}

private fun showNoPermissionNotification() {
Handler(Looper.getMainLooper()).postDelayed(delayInMillis = 100L) {
Expand All @@ -99,6 +102,12 @@ class PlaybackService : MediaLibraryService(), MediaSessionService.Listener {
// todo: show a notification instead.
}

override fun onTaskRemoved(rootIntent: Intent?) {
playerHandler.post {
super.onTaskRemoved(rootIntent)
}
}

companion object {
// Initializing a media controller might take a noticeable amount of time thus we expose current playback info here to keep things as quick as possible.
var isPlaying: Boolean = false
Expand Down
Loading