fix: prevent app close on sleep timer reset#382
Open
IDS-YN wants to merge 1 commit intoFossifyOrg:mainfrom
Open
fix: prevent app close on sleep timer reset#382IDS-YN wants to merge 1 commit intoFossifyOrg:mainfrom
IDS-YN wants to merge 1 commit intoFossifyOrg:mainfrom
Conversation
Second file edit for the fixe of this bug: FossifyOrg#345 Changed the logic for PlaybackService.toggleSleepTimer() to be sure the sleeptimer stops when the timer hits 0 and that the timer starts/keeps going at 0 of above so when there's already a sleeptimer set it wont cause a problem. New val sleepTimerCurrent corresponds to current value in the timer, hope it stays in style with the writing code. Once again sorry for making the pull in two requests instead of one.
naveensingh
requested changes
Feb 14, 2026
Member
naveensingh
left a comment
There was a problem hiding this comment.
Once again sorry for making the pull in two requests instead of one.
You can make changes to this PR's branch directly using GitHub. Just redo the changes from your first PR https://github.com/FossifyOrg/Music-Player/pull/381/changes to the file located here: MainActivity.kt (click to edit)
Thanks.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second file edit for the fixe of this bug: #345
Changed the logic for PlaybackService.toggleSleepTimer() to be sure the sleeptimer stops when the timer hits 0 and that the timer starts/keeps going at 0 of above so when there's already a sleeptimer set it wont cause a problem. New val sleepTimerCurrent corresponds to current value in the timer, hope it stays in style with the writing code.
Once again sorry for making the pull in two requests instead of one.
Type of change(s)
What changed and why
Tests performed
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).