Skip to content

Add lucene coverage to overall report #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 14, 2025

Conversation

ScottDugas
Copy link
Collaborator

@ScottDugas ScottDugas commented Aug 8, 2025

Currently Lucene and other classes are not being included in the overall coverage report on a PR. This fixes that by doing two things:

  1. Publish the jars along with coverage data, as those are needed to process the .exec files that jacoco uses
  2. download the coverage data from sub-jobs as separate tasks. Otherwise it removes the hierarchy.

@ScottDugas ScottDugas added testing improvement Change that improves our testing build improvement Improvement to the build system labels Aug 11, 2025
@ScottDugas ScottDugas changed the title Log downloaded artifacts Add lucene coverage to overall report Aug 11, 2025
@ScottDugas ScottDugas requested a review from alecgrieser August 11, 2025 19:05
@ScottDugas ScottDugas marked this pull request as ready for review August 11, 2025 19:05
@alecgrieser alecgrieser merged commit 5fc17e0 into FoundationDB:main Aug 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build improvement Improvement to the build system testing improvement Change that improves our testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants