Skip to content

Add lucene coverage to overall report #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 14, 2025
+23 −7
Merged

Add lucene coverage to overall report #3538

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d162862
Log downloaded artifacts
ScottDugas Aug 8, 2025
54c8d8d
Try not merging multiple
ScottDugas Aug 8, 2025
fe4b529
Download individually
ScottDugas Aug 8, 2025
6e4e537
Put individually downloaded files in the root
ScottDugas Aug 8, 2025
b910377
Publish the jars for coverage too
ScottDugas Aug 8, 2025
ef4ba29
Try compiling the java code
ScottDugas Aug 8, 2025
1f4f3c4
Build jars in subprojects
ScottDugas Aug 8, 2025
ff1dcea
Publish jars for other-tests
ScottDugas Aug 11, 2025
7e81c16
We need the core jar for other tests to pass, may need lucene at some…
ScottDugas Aug 11, 2025
30c4536
Remove logging
ScottDugas Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Run Gradle Test
uses: ./actions/gradle-test
with:
gradle_command: :fdb-record-layer-core:test :fdb-record-layer-core:destructiveTest
gradle_command: :fdb-record-layer-core:jar :fdb-record-layer-core:test :fdb-record-layer-core:destructiveTest
gradle_args: -PreleaseBuild=false -PpublishBuild=false
- name: Publish Test Reports
if: always()
Expand All @@ -61,6 +61,7 @@ jobs:
name: core-coverage-data
path: |
**/.out/jacoco/*.exec
**/.out/libs/*.jar
include-hidden-files: true
retention-days: 1

Expand All @@ -80,7 +81,7 @@ jobs:
- name: Run Gradle Test
uses: ./actions/gradle-test
with:
gradle_command: :fdb-record-layer-lucene:test :fdb-record-layer-lucene:destructiveTest
gradle_command: :fdb-record-layer-lucene:jar :fdb-record-layer-lucene:test :fdb-record-layer-lucene:destructiveTest
gradle_args: -PreleaseBuild=false -PpublishBuild=false
- name: Publish Test Reports
if: always()
Expand All @@ -95,6 +96,7 @@ jobs:
name: lucene-coverage-data
path: |
**/.out/jacoco/*.exec
**/.out/libs/*.jar
include-hidden-files: true
retention-days: 1

Expand All @@ -114,7 +116,13 @@ jobs:
- name: Run Gradle Test
uses: ./actions/gradle-test
with:
gradle_command: test -x :fdb-record-layer-core:test -x :fdb-record-layer-lucene:test destructiveTest -x :fdb-record-layer-core:destructiveTest -x :fdb-record-layer-lucene:destructiveTest
gradle_command: >-
test
-x :fdb-record-layer-core:test
-x :fdb-record-layer-lucene:test
destructiveTest
-x :fdb-record-layer-core:destructiveTest
-x :fdb-record-layer-lucene:destructiveTest
gradle_args: -PreleaseBuild=false -PpublishBuild=false
- name: Publish Test Reports
if: always()
Expand Down Expand Up @@ -156,12 +164,20 @@ jobs:
uses: actions/[email protected]
- name: Setup Base Environment
uses: ./actions/setup-base-env
- name: 'Download artifacts'
# It looks like, if you try to download them all as a pattern, the nested directories get stripped
# so the coverage data (for e.g. lucene) does not end up in the appropirate subproject directory
- name: 'Download lucene'
uses: actions/download-artifact@v4
with:
name: lucene-coverage-data
- name: 'Download core'
uses: actions/download-artifact@v4
with:
pattern: |
*-coverage-data
merge-multiple: true
name: core-coverage-data
- name: 'Download other'
uses: actions/download-artifact@v4
with:
name: other-coverage-data
- name: Run JaCoCo Report
uses: ./actions/run-gradle
with:
Expand Down