Add OTA Orchestrator fixes #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not suspend OTA agent after successful update. * vOtaNotActiveHook() should be called whenever there are no OTA jobs available. * Use LogDebug and LogError instead of LogInfo to follow the previous ota-for-embedded-iot-sdk library implementation (avoiding new issues). Signed-off-by: Devaraj Ranganna <[email protected]> Signed-off-by: Ahmed Ismail <[email protected]>
The `MQTT_AGENT_KEEP_ALIVE_INTERVAL_SECONDS` is increased to 100 as in case of using SOFTWARE inference with speech recognition application the connection is dropped before the ML Inference is done as the software inference is generally much slower compared to the Ethos NPU. This connection drop cause the ML inference to have wrong results as the task is interrupted. Hence, increasing the keep alive interval to avoid the connection drop. Signed-off-by: Ahmed Ismail <[email protected]>
actions/upload-artifact v3 is now deprecated and cannot be used anymore. Hence, updating to v4. `strategy.job-index` is post-fixed to the artifact name to overcome the known issue of upload-artifact v4 not allowing multiple artifacts with the same name on the workflow run. Signed-off-by: Ahmed Ismail <[email protected]>
AhmedIsmail02
force-pushed
the
add-ota-orchestrator-fixes
branch
from
78a1b9e to
58e20cb
Compare
urutva
approved these changes
Jan 31, 2025
ig15
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes done as part of this PR:
Do not suspend OTA agent after successful update.
vOtaNotActiveHook()should be called whenever there are no OTA jobs available.Use
LogDebugandLogErrorinstead ofLogInfoto follow the previousota-for-embedded-iot-sdklibrary implementation (avoiding new issues).The
MQTT_AGENT_KEEP_ALIVE_INTERVAL_SECONDSis increased to100as in case of usingSOFTWAREinference withspeech-recognitionapplication the connection is dropped before the ML Inference is done as the software inference is generally much slower compared to the Ethos NPU. This connection drop cause the ML inference to have wrong results as the task is interrupted. Hence, increasing the keep alive interval to avoid the connection drop.Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.