Fix conflicts with DISPLAY system wide variable #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of setuptools (59.6.0) is too old to meet the requirements of the packages installed during the pre-commit stage. To avoid conflicts with system packages, a virtual environment was used to do so. Signed-off-by: Ahmed Ismail <[email protected]>
Ml-Embedded-Evaluation-kit GitLab repos are now live and public. Hence switching to using them. Changes done in this commit: * Update the submodule for MLEK to use the public GitLab instance. * Update the docs to refer to the public MLEK GitLab instance. Signed-off-by: Ahmed Ismail <[email protected]>
`DISPLAY` is a well-known system-wide variable used in Linux for GUI applications. Overwriting it in the script could lead to unintended side effects, especially when launching graphical applications. Renaming it to HDLCD_GUI to avoid such conflicts. Signed-off-by: Ahmed Ismail <[email protected]>
AhmedIsmail02
force-pushed
the
fix-conflicts-with-system-wide-variable
branch
from
e661f89 to
03dd4f6
Compare
aggarg
approved these changes
Mar 20, 2025
tony-josi-aws
approved these changes
Mar 20, 2025
kar-rahul-aws
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DISPLAYis a well-known system-wide variable used in Linux for GUI applications. Overwriting it in the script could lead to unintended side effects, especially when launching graphical applications. Renaming it toHDLCD_GUIto avoid such conflicts.The current version of
setuptools(59.6.0) is too old to meet the requirements of the packages installed during the pre-commit stage. To avoid conflicts with system packages, a virtual environment is used to updatesetuptoolsand then run pre-commit stage in internal CI.Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.