Hotfix: use system-provided cyrus-sasl/libsasl2 at runtime #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make sure that the specific version of librdkafka.redist can be restored - make sure that the tag and project versions match - handle versions with build metadata
| <Title>Confluent.Kafka</Title> | ||
| <AssemblyName>Confluent.Kafka</AssemblyName> | ||
| <VersionPrefix>2.11.0</VersionPrefix> | ||
| <VersionPrefix>2.11.0.1-RC1+gr</VersionPrefix> |
There was a problem hiding this comment.
I guess that should be a Version, not a VersionPrefix if we specify the entire version here. But as far as I remember, it doesn't matter - VersionPrefix works too.
There was a problem hiding this comment.
It works with VersionPrefix, but I'm happy to change it to Version. I was trying to minimise changes from upstream!
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="librdkafka.redist" Version="2.11.0-gr"> | ||
| <PackageReference Include="librdkafka.redist" Version="2.11.0.1-RC1+gr"> |
There was a problem hiding this comment.
This is fine, but note that the +gr suffix doesn't have any effect here; it would work the same with 2.11.0.1-RC1
marcin-krystianc
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
librdkafka.redistcan be restoredlibrdkafka.redistversion2.11.0.1-RC1+gr)2.11.0.1-RC1+gr