Merged
Conversation
Test Results 18 files 18 suites 5s ⏱️ Results for commit 2b9950f. ♻️ This comment has been updated with latest results. |
hwangjokim
reviewed
Mar 30, 2025
| }; | ||
| } | ||
|
|
||
| static private String createClientEndpoint(String apiType) { |
hwangjokim
reviewed
Mar 30, 2025
hwangjokim
requested changes
Mar 30, 2025
src/main/resources/application.yml
Outdated
| enable: true | ||
| # 기본 도메인 값 (dev 환경 기본) | ||
| api: | ||
| domain: dev.algohub.kr |
hwangjokim
reviewed
Mar 30, 2025
| private final JavaMailSender mailSender; | ||
| private final TemplateEngine templateEngine; | ||
|
|
||
| @Value("${app.type:dev}") |
hwangjokim
reviewed
Mar 30, 2025
src/main/resources/application.yml
Outdated
| properties: | ||
| hibernate: | ||
| format_sql: true | ||
| # dev 환경 도메인은 common에 정의되어 있으므로 중복 설정하지 않음 |
hwangjokim
reviewed
Mar 30, 2025
src/main/resources/application.yml
Outdated
Comment on lines
+126
to
+127
| api: | ||
| domain: rc.algohub.kr |
hwangjokim
requested changes
Mar 30, 2025
Contributor
hwangjokim
left a comment
hwangjokim
left a comment
There was a problem hiding this comment.
구두로 설명드렸는데 총체적으로 뭔가 이상합니다..
이따 봐주세요
hwangjokim
reviewed
Mar 30, 2025
| } | ||
|
|
||
| static private String createClientEndpoint(String apiType) { | ||
| if ("rc".equals(appType)) { |
Contributor
Author
|
어제 전체적으로 되게 이상하게 짰었네요,, 오늘 정신좀 차리고 다시 짜놨습니다 보고 확인해주세요~! |
hwangjokim
requested changes
Apr 1, 2025
Comment on lines
+34
to
+35
| private String EMAIL_VERIFICATION_CLIENT_ENDPOINT; | ||
| private String RESET_PASSWORD_CLIENT_ENDPOINT; |
Contributor
There was a problem hiding this comment.
이제 상수가 아니니까 선언을 제거하고, 함수 내부에서 변수로 선언해주세요. 네이밍 케이스도 카멜케이스로 수정 부탁드리구요
| } | ||
|
|
||
| private String createClientEndpoint(String apiType) { | ||
| System.out.println(activeProfile); |
Comment on lines
+111
to
+116
| @PostConstruct | ||
| private void init() { | ||
| this.EMAIL_VERIFICATION_CLIENT_ENDPOINT = createClientEndpoint("signup"); | ||
| this.RESET_PASSWORD_CLIENT_ENDPOINT = createClientEndpoint("reset-password"); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
그냥 요거 없애고 createClientEndpoint 내부에서 하게 해주세요
hwangjokim
approved these changes
Apr 1, 2025
s-hwan
approved these changes
Apr 2, 2025
Contributor
s-hwan
left a comment
s-hwan
left a comment
There was a problem hiding this comment.
무수한 황조님의 comment 잘 봤습니다
아직도 email service가 어떻게 돌아가는지 잘 모르겠어요 전ㅜㅜㅠ
hwangjokim
pushed a commit
that referenced
this pull request
Apr 8, 2025
* refactor : 이메일 검증 API // rc, prod endpoint구분 * refactor : 이메일 검증 API // yml파일 중복부분 수정 * refactor : 이메일 검증 API // yml파일 중복부분 수정2트 * refactor : 이메일 검증 API // 피드백 반영 * refactor : 이메일 검증 API // 피드백 반영22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Related Issue
https://linear.app/algo-hub/issue/BE-5/refactor-%EC%9D%B4%EB%A9%94%EC%9D%BC-%EA%B2%80%EC%A6%9D-api
🚀 Description
return url을 rc서버, prod서버 따로따로 설정하도록 했습니다~!
📢 Review Point
한게 별로 없어서 스윽 봐주세용