Skip to content

refactor : 이메일 검증 API #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sh0723 merged 5 commits into from
Apr 2, 2025
Merged

refactor : 이메일 검증 API #364

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fe635e
refactor : 이메일 검증 API // rc, prod endpoint구분
sh0723 Mar 30, 2025
cb1a7c8
refactor : 이메일 검증 API // yml파일 중복부분 수정
sh0723 Mar 30, 2025
4274af8
refactor : 이메일 검증 API // yml파일 중복부분 수정2트
sh0723 Mar 30, 2025
666fecd
refactor : 이메일 검증 API // 피드백 반영
sh0723 Mar 31, 2025
2b9950f
refactor : 이메일 검증 API // 피드백 반영22
sh0723 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions src/main/java/com/gamzabat/algohub/feature/user/service/EmailService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import java.util.concurrent.CompletableFuture;

import org.springframework.beans.factory.annotation.Value;
import org.springframework.mail.javamail.JavaMailSender;
import org.springframework.mail.javamail.MimeMessageHelper;
import org.springframework.retry.annotation.Recover;
Expand All @@ -15,6 +16,7 @@
import com.gamzabat.algohub.enums.EmailType;
import com.gamzabat.algohub.exception.MessagingRuntimeException;

import jakarta.annotation.PostConstruct;
import jakarta.mail.MessagingException;
import jakarta.mail.internet.MimeMessage;
import lombok.RequiredArgsConstructor;
Expand All @@ -24,9 +26,13 @@
@RequiredArgsConstructor
@Slf4j
public class EmailService {

@Value("${spring.profiles.active:dev}")
private String activeProfile;

private static final String FROM_ADDRESS = "noreply@algohub.kr";
private static final String EMAIL_VERIFICATION_CLIENT_ENDPOINT = "https://algohub.kr/signup";
private static final String RESET_PASSWORD_CLIENT_ENDPOINT = "https://algohub.kr/reset-password";
private String EMAIL_VERIFICATION_CLIENT_ENDPOINT;
private String RESET_PASSWORD_CLIENT_ENDPOINT;
Copy link
Contributor

@hwangjokim hwangjokim Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 상수가 아니니까 선언을 제거하고, 함수 내부에서 변수로 선언해주세요. 네이밍 케이스도 카멜케이스로 수정 부탁드리구요

private final JavaMailSender mailSender;
private final TemplateEngine templateEngine;

Expand All @@ -51,7 +57,6 @@ private void sendMail(String recipient, EmailType type, String content) {
try {
MimeMessage message = mailSender.createMimeMessage();
MimeMessageHelper helper = new MimeMessageHelper(message, true, "UTF-8");

helper.setTo(recipient);
helper.setFrom(FROM_ADDRESS);
helper.setSubject(getEmailSubject(type));
Expand Down Expand Up @@ -102,4 +107,20 @@ private String getEmailSubject(EmailType type) {
default -> throw new IllegalArgumentException("LOGIC ERROR : Unreachable code block");
};
}

@PostConstruct
private void init() {
this.EMAIL_VERIFICATION_CLIENT_ENDPOINT = createClientEndpoint("signup");
this.RESET_PASSWORD_CLIENT_ENDPOINT = createClientEndpoint("reset-password");
}

Copy link
Contributor

@hwangjokim hwangjokim Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그냥 요거 없애고 createClientEndpoint 내부에서 하게 해주세요

private String createClientEndpoint(String apiType) {
System.out.println(activeProfile);
Copy link
Contributor

@hwangjokim hwangjokim Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건뭐죠.. 로거도 아니고..


if ("prod".equals(activeProfile)) {
return ("https://algohub.kr/" + apiType);
} else {
return ("https://rc.algohub.kr/" + apiType);
}
}
}
5 changes: 0 additions & 5 deletions src/main/resources/application.yml
View file
Open in desktop
Copy link
Contributor

@hwangjokim hwangjokim Mar 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???????????????

Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ spring:
rc:
- dev
- common

---
spring:
config:
Expand All @@ -23,19 +22,16 @@ spring:
driver-class-name: com.mysql.cj.jdbc.Driver
username: ${mysql_username}
password: ${mysql_password}

jpa:
database: mysql
database-platform: org.hibernate.dialect.MySQLDialect
open-in-view: false
hibernate:
ddl-auto: update

servlet:
multipart:
max-file-size: 5MB
max-request-size: 6MB

data:
redis:
host: localhost
Expand Down Expand Up @@ -64,7 +60,6 @@ cloud:
credentials:
access-key: ${aws_access_key}
secret-key: ${aws_secret_key}

logging:
config: classpath:logback-spring.xml
server:
Expand Down