Add missing commits to GCMv12 branch #116
Conversation
|
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Please add one so that the PR can be merged. |
biljanaorescanin
added
0 diff trivial
| @@ -121,6 +124,13 @@ def ask_questions(): | |||
| "validate": lambda text: validate_geosit_time(text), | |||
| "when": lambda x: x.get("input:shared:GEOS-IT", False) and not x.get("input:shared:MERRA-2", False), | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Oooh. This one is tricky. By default, GEOSgcm v12 is non-hydrostatic. So, anyone remapping from v12 to v12+ would prefer this to be True by default. But then, anyone remapping anything older (v11, say) would want True
I am not sure what to do here. @wmputman might have more insight.
There was a problem hiding this comment.
Yes, I think this makes also issues for coupled runs from older restarts. Coupled restarts are always hydrostatic I think.
@wmputman what should be our defaults?
There was a problem hiding this comment.
@biljanaorescanin "Coupled restarts are always hydrostatic" well...huh. I did not know that. I've been doing any test MOM6 runs with v12 as non-hydro.
Maybe @wmputman has FV3 setup in such a way now that it doesn't matter? If not, I know MERRA-2 is hydrostatic but what about GEOS-IT? I assume it is, but since @biljanaorescanin added GEOS-IT we'd probably want some default for that too.
|
@mathomp4 @wmputman @sdrabenh @zhaobin74 what we need to do is go from Currently remap will skip remapping upper. I think it is due to hydrostatic option. But I will see with @weiyuan-jiang how to fix this once we know what it needs to be. Update: |
Somehow during branch sinking some commits got lost and we just noticed now during coupled run testing.
Issue was hydrostatic question.
To test this PR we need
GCMv12-rc10and its branches.These commits were originally on #61