Skip to content

Conversation

@saraqzhang
Copy link
Contributor

@saraqzhang saraqzhang commented Jan 27, 2025

for integrated setup of adas and ldas, modifications and updates are implemented in fvsetup and several scripts and rc files that are used in the fvsetup procedure. the modifications to other related external components and ldas are updated by pull requests to the corresponding repositories.

Related PR: GEOS-ESM/GEOSldas_GridComp#81 (merged; follow-up PR in prep)

Requires:
GEOS-ESM/GEOSgcm_App#689 (merged)
GEOS-ESM/GMAO_Shared#370 (merged)

@saraqzhang saraqzhang added enhancement New feature or request 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Jan 27, 2025
@saraqzhang
Copy link
Contributor Author

@rtodling @gmao-jstassi @gmao-rreichle This PR ( draft) contains the updates we presented last meeting (1/22/2025). these updates have been tested in a hybrid 4dnvar experiment ( integrated setup and one-day cycling) . Next we are going to implement the update to make lfo forcing as bkg files in the setup, workflow and archive. There will be corresponding development and updates in ldasGC src.

Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saraqzhang : I added a very minor commit (removing Haswell and Skylake choices) and a couple of inline comments

@saraqzhang
Copy link
Contributor Author

@gmao-rreichle @gmao-jstassi @rtodling
we added the further updates for land forcing "lfo" as bkg in setup and in hybrid da cycling. The updated system passed the tests on setup and a hybrid LADAS cycling.

Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saraqzhang, I added a few inline comments. I might be wrong on some (or even all of them), but take a look and see if any of the suggested changes make sense

@gmao-rreichle gmao-rreichle removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Mar 11, 2025
@gmao-rreichle
Copy link
Contributor

@saraqzhang, @gmao-jstassi, @rtodling : I see that fvsetup maintains lists of files for the ADAS components. E.g., for chemistry:

@chem_files = qw ( Aod3d_1064nm.rc

Looking towards improving the LDAS integration going forward, do we need to think about having such a list for the LDAS files? For example, LDAS needs nml input files that define the land model perturbations and the obs that it assimilates. (These files are in plain vanilla Fortran nml format, but they're essentially rc files.)

@rtodling
Copy link
Collaborator

rtodling commented May 5, 2025

I am working on this ... please don't make changes anymore @saraqzhang @gmao-jstassi

Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed references to older architectures in fvsetup to what they were ... I will make sure those get changed ( and removed, as this originally attempted) but in a general wya - w/ the *input files changing accordingly.

@rtodling rtodling merged commit 8e56741 into develop May 5, 2025
2 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/saraqzhang/updatesetup4ladas branch May 5, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants