-
Notifications
You must be signed in to change notification settings - Fork 3
update setup procedures for LADAS #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rtodling @gmao-jstassi @gmao-rreichle This PR ( draft) contains the updates we presented last meeting (1/22/2025). these updates have been tested in a hybrid 4dnvar experiment ( integrated setup and one-day cycling) . Next we are going to implement the update to make lfo forcing as bkg files in the setup, workflow and archive. There will be corresponding development and updates in ldasGC src. |
gmao-rreichle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saraqzhang : I added a very minor commit (removing Haswell and Skylake choices) and a couple of inline comments
src/Applications/NCEP_Etc/NCEP_enkf/scripts/gmao/etc/HISTAENS.rc.tmpl
Outdated
Show resolved
Hide resolved
|
@gmao-rreichle @gmao-jstassi @rtodling |
gmao-rreichle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saraqzhang, I added a few inline comments. I might be wrong on some (or even all of them), but take a look and see if any of the suggested changes make sense
src/Applications/NCEP_Etc/NCEP_enkf/scripts/gmao/etc/HISTAENS.rc.tmpl
Outdated
Show resolved
Hide resolved
src/Applications/NCEP_Etc/NCEP_enkf/scripts/gmao/get_atmens_rst.pl
Outdated
Show resolved
Hide resolved
modified: src/Applications/GEOSdas_App/fvsetup modified: src/Applications/NCEP_Etc/NCEP_enkf/scripts/gmao/get_atmens_rst.pl
modified: fvsetup
modified: AGCMrc.pm
modified: components.yaml
|
@saraqzhang, @gmao-jstassi, @rtodling : I see that fvsetup maintains lists of files for the ADAS components. E.g., for chemistry: GEOSadas/src/Applications/GEOSdas_App/fvsetup Line 922 in a4e6c0c
Looking towards improving the LDAS integration going forward, do we need to think about having such a list for the LDAS files? For example, LDAS needs nml input files that define the land model perturbations and the obs that it assimilates. (These files are in plain vanilla Fortran nml format, but they're essentially rc files.) |
|
I am working on this ... please don't make changes anymore @saraqzhang @gmao-jstassi |
rtodling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed references to older architectures in fvsetup to what they were ... I will make sure those get changed ( and removed, as this originally attempted) but in a general wya - w/ the *input files changing accordingly.
for integrated setup of adas and ldas, modifications and updates are implemented in fvsetup and several scripts and rc files that are used in the fvsetup procedure. the modifications to other related external components and ldas are updated by pull requests to the corresponding repositories.
Related PR: GEOS-ESM/GEOSldas_GridComp#81 (merged; follow-up PR in prep)
Requires:
GEOS-ESM/GEOSgcm_App#689 (merged)
GEOS-ESM/GMAO_Shared#370 (merged)