Skip to content

add checking and setting restart flag in CICE6 config file in gcm_run#724

Merged
sdrabenh merged 6 commits intodevelopfrom
feature/zhaobin74/cice6-config-upd
Jun 27, 2025
Merged

add checking and setting restart flag in CICE6 config file in gcm_run#724
sdrabenh merged 6 commits intodevelopfrom
feature/zhaobin74/cice6-config-upd

Conversation

@zhaobin74
Copy link
Contributor

This PR added a step of restart checking and config updating if certain field exist in CICE6 restart file.
This is necessary due to change in GEOS-ESM/GEOSgcm_GridComp#1101

@zhaobin74 zhaobin74 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label May 5, 2025
@zhaobin74 zhaobin74 requested a review from a team as a code owner May 5, 2025 20:10
@zhaobin74 zhaobin74 added the CICE6 label May 5, 2025
@mathomp4
Copy link
Member

mathomp4 commented May 5, 2025

Oooh boy. This is sort of scary that we are calling ncdump in this. I'm not sure we are guaranteed to have ncdump on the PATH. We don't usually add the Baselibs bin directory to the PATH, though I suppose it would be on Spack.

I wonder if it might be more portable (if more annoying) to make our own Fortran program to do this detection?

@zhaobin74
Copy link
Contributor Author

zhaobin74 commented May 5, 2025

Oooh boy. This is sort of scary that we are calling ncdump in this. I'm not sure we are guaranteed to have ncdump on the PATH. We don't usually add the Baselibs bin directory to the PATH, though I suppose it would be on Spack.

I wonder if it might be more portable (if more annoying) to make our own Fortran program to do this detection?

Thanks, @mathomp4. Yeah, relying on ncdump is not good.
Is there anything in current GEOS that could achieve that? Just need to check if certain fields exist in the .nc file.

@mathomp4
Copy link
Member

mathomp4 commented May 5, 2025

@zhaobin74 I am not sure. I'll ask around our group as we might have something.

If not, the program would be pretty trivial I bet. Only question is: where to put it in GEOS. I'll get back to you, if nothing else, with something to test.

@mathomp4
Copy link
Member

mathomp4 commented May 6, 2025

@zhaobin74 Actually, ncdump might just be as easy as anything else. Do you mind if I push an update to this and then you can test it out?

@zhaobin74
Copy link
Contributor Author

zhaobin74 commented May 6, 2025

@zhaobin74 Actually, ncdump might just be as easy as anything else. Do you mind if I push an update to this and then you can test it out?

@mathomp4, not at all. Feel free to push. Just wonder if ncdump is universally available in all systems GEOS runs on. In fact, I am building a small Fortran utility to replace ncdump.

@mathomp4
Copy link
Member

mathomp4 commented May 6, 2025

@zhaobin74 Actually, ncdump might just be as easy as anything else. Do you mind if I push an update to this and then you can test it out?

@mathomp4, not at all. Feel free to push. Just wonder if ncdump is universally available in all systems GEOS runs on. In fact, I am building a small Fortran utility to replace ncdump.

@zhaobin74 I mean, yes, it should be. We have two cases we might be in:

  1. We use Baselibs and well, Baselibs has ncdump
  2. We use Spack and we'd have it there too

@mathomp4
Copy link
Member

mathomp4 commented May 6, 2025

Okay. I pushed up a small change. Essentially added the Baselibs bin to the PATH. Of course, if a user already has ncdump in their PATH that'll win.

@zhaobin74
Copy link
Contributor Author

Okay. I pushed up a small change. Essentially added the Baselibs bin to the PATH. Of course, if a user already has ncdump in their PATH that'll win.

Thanks, @mathomp4. As long as ncdump is built as part of the Baselib, it should work.

@sdrabenh sdrabenh merged commit 7424588 into develop Jun 27, 2025
12 checks passed
@sdrabenh sdrabenh deleted the feature/zhaobin74/cice6-config-upd branch June 27, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. CICE6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants