-
Notifications
You must be signed in to change notification settings - Fork 9
add make_topo scripts to generate topography files on BC #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…_GridComp into feature/wjiang/add_topo
Summary of code testing: @wmputman do these numbers look OK to you? All verification on my side global plots/zoom in plots look ok. I've created a directory you can use to test to see do output files behave as you expect. I also tried fix you suggested for c5760 but it didn't work. Maybe SI-Team can figure that one out. |
@biljanaorescanin @weiyuan-jiang We need updates to The things needed are global attributes like:
I want to say you'd do things like: ncFidOut.STRETCH_FACTOR=2.5
ncFidOut.TARGET_LAT=39.5
ncFidOut.TARGET_LON=-98.35 or something like that? I'm not the best at Python netcdf. @bena-nasa might know the right thing. But the script needs some way to know if things are stretched. |
@mathomp4 @bena-nasa I've made changes and tested it will add attributes like this at the end, for example here is from c540 : and regular grid is same as before I've tried c24. I hope this is what you had in mind. |
@biljanaorescanin I think you got it! |
1c15a7c
I've run all resolutions and updated TOPO set on bcs_shared path (v14_BETA/TOPO) with this branch as it is now and TOPO tag 2.1.0. I think at this point is at good stage to test and see how it behaves in runs. All in magnitude compares well to what Replay_Experiments/c360 for example has in scratch/gwd_internal_rst file. Few notes for future regarding gwd_internal_rst:More cleanup in sense more metadata inconstancies I didn't catch at first but it is really not going to affect the model it is just truthful representation what nc4 values are as far as description in metadata.
it should be Line for example: FYI: GEOS only uses ANGLL and this won't be an issue since from code on develop it has this check in code: GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSgwd_GridComp/GEOS_GwdGridComp.F90 Lines 613 to 617 in 75599de
Other ANGLX is never used in GEOS it is internal for topo package. Still right way is to fix sentinel to -9000 and possibly normalize so value is right range for angle: 0-180.
GEOS doesn't use this var it is for NCAR plotting package only (ncl script). Name is here misleading it says in metadata LANDFRAC is fraction of grid cell leading us to belive values should then be 0-1 but we don't see that in gwd_internal_rst file we see: so we can fix this in code but we don't use it so I didn't mess with it. in this code this line: We need to use the decoded fraction in the binning, not the raw byte.
so one option is to make area like m**2? That info feels maybe more useful so we don't repeat same info in restart. Again now all of this is mostly cleanup and cosmetic. Final taught: |
Add make_topo scripts to generate topography files on BC.
PR needs this topo branch to work for stretched grids:
GEOS-ESM/Topo#1