-
Notifications
You must be signed in to change notification settings - Fork 9
Updates to add new Catchment-CN version: Catchment-CN5.1 #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments below
...agcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/mk_restarts/CatchmentCNRst.F90
Outdated
Show resolved
Hide resolved
...agcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/mk_restarts/CatchmentCNRst.F90
Outdated
Show resolved
Hide resolved
...agcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/mk_restarts/CatchmentCNRst.F90
Show resolved
Hide resolved
...agcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/mk_restarts/CatchmentCNRst.F90
Outdated
Show resolved
Hide resolved
...agcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/mk_restarts/CatchmentCNRst.F90
Outdated
Show resolved
Hide resolved
…the nwarning issue needs to be looked into if it persists after spinup is complete
… of CLM40 variables description
…tate.F90, GEOS_CatchCNGridComp.F90, CNCLM_init_mod.F90)
GCM 1 day AMIP, REPLAY and Inc Replay are zero diff. |
CatchCN CLM4.0 restart remapping compared from what I get using main GEOS_Util to what we get with GEOS-Util pr and this PR is zero diff for both m36 and c180 runs. Restart I used to remap from was one I created for Eunjee when she wanted to run v12 bcs. Also, I forgot to say regression was also run as part of GCM testing on the exp PR and it was a PASS. |
…mp/GEOScatchCN_GridComp/GEOS_CatchCNGridComp.F90)
Updates on my part:
|
…and bad Z0_FORMULATION=1 (GEOS_SurfaceGridComp.rc, lsm_routines.F90, GEOS_CatchGridComp.F90, GEOS_CatchCNCLM51GridComp.F90)
…GEOS_CatchGridComp.F90, GEOS_CatchCNCLM51GridComp.F90)
...GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_GridComp/Shared/lsm_routines.F90
Show resolved
Hide resolved
I think the error is on this line Line 2728 in 6f95da3
GNU fails to recognize that is a comment |
This PR introduces the new version Catchment-CN5.1 land model, based on the Community Terrestrial System Model version 5.1 (CTSM5.1). Most of the files related to Catchment-CN5.1 are contained in the subdirectory ./GEOScatchCNCLM51_GridComp.
Documentation for Catchment-CN5.1 was added here:
[..]/GEOScatchCN_GridComp/GEOScatchCNCLM51_GridComp/README_CN51.md
Source code for Catchment-CN4.5 was removed throughout, except in the make_bcs package where the generation of model parameters for Catchment-CN4.5 is still needed for Catchment-CN5.1.
It is expected that the "remap_restarts" package is zero-diff for Catchment-CN4.0. There were, however, several bugs in CatchmentCNRst.F90 for Catchment-CN4.5 that were fixed for Catchment-CN5.1.
Related PRs (in the order in which they should be merged):
Outstanding issues to be resolved before merge:
To be addressed in a future PR:
cc: @gmao-rreichle , @rdkoster , @weiyuan-jiang , @biljanaorescanin