Conversation
- changed default to NOT use extra derivs - renamed resource variable for extra derivs - reordered and moved variable declarations etc for consistency
…ge coeffs; fixed typos in comments
…S_SurfaceGridComp.rc)
…itional call to louissurface() (GEOS_CatchGridComp.F90, catch_wrap_state.F90)
Contributor
|
@gmao-rreichle here is testing summary:
|
…larity (GEOS_Catch*GridComp.F90, catch_wrap_state.F90)
…VS_OFFL_LAND (GEOS_SurfaceGridComp.rc)
Contributor
|
I've redone tests since it has been a while:
Comparing NC4 catch_internal_checkpoint using nccmp...
|
biljanaorescanin
approved these changes
May 27, 2025
Contributor
sdrabenh
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #918. Adds optional numerical derivatives of Monin-Obukhov exchange coefficients over land in offline mode. Numerical derivatives implemented for Louis and Helfand. Also cleans up and documents surface turbulence code in Catchment GridComp. Numerical derivatives not yet implemented for CatchCN.
New resource parameter
MOSFC_EXTRA_DERIVS_LANDreplacesincl_Louis_extra_derivs:Successfully 0-diff tested for GEOSldas Intel standard tests at 3b6cced