Skip to content

Conversation

gmao-jkolassa
Copy link
Contributor

@gmao-jkolassa gmao-jkolassa commented Jul 1, 2025

This PR introduces the new version Catchment-CN5.1 land model, based on the Community Terrestrial System Model version 5.1 (CTSM5.1).

The addition of Catchment-CN5.1 requires updates to the GEOSgcm_GridComp and GEOSldas_GridComp:

  • GEOSgcm_GridComp PR 1129
  • GEOSldas_GridComp PR 132
  • GEOS_Util PR 149

Before merging this PR, update GEOS_Util tag in components.yaml.

cc: @biljanaorescanin, @gmao-rreichle , @rdkoster , @weiyuan-jiang

@gmao-rreichle
Copy link
Contributor

Outstanding issues
The model requires support for 0-rank strings for the netcdf file formatter function get_var, which is included in MAPL develop, but not in any of the recent MAPL tags. Once the current MAPL develop is released in a new tag, to components.yaml file will have to be updated to that tag.

@gmao-jkolassa : Thanks for creating the PR. Isn't MAPL v2.57.0 sufficient? It's less than 2 weeks old. I don't know what was changed to support the rank-0 strings, but it doesn't look like the only two commits the came after v2.57.0 are related to it:
GEOS-ESM/MAPL#3853
GEOS-ESM/MAPL#3837
Maybe v2.57.0 has what you need, after all?

@gmao-jkolassa
Copy link
Contributor Author

Outstanding issues
The model requires support for 0-rank strings for the netcdf file formatter function get_var, which is included in MAPL develop, but not in any of the recent MAPL tags. Once the current MAPL develop is released in a new tag, to components.yaml file will have to be updated to that tag.

@gmao-jkolassa : Thanks for creating the PR. Isn't MAPL v2.57.0 sufficient? It's less than 2 weeks old. I don't know what was changed to support the rank-0 strings, but it doesn't look like the only two commits the came after v2.57.0 are related to it: GEOS-ESM/MAPL#3853 GEOS-ESM/MAPL#3837 Maybe v2.57.0 has what you need, after all?

You're right, that change was merged in MAPL v2.57.0, I just didn't see it. I have changed the components.yaml file to use MAPL v2.57.0.

@gmao-rreichle
Copy link
Contributor

@gmao-jkolassa : I changed the "Not 0-diff" label to "0-diff" (same for GEOS-ESM/GEOSldas_GridComp#132). We are only adding a new model option, which should not cause any changes to existing model options. Simulations with Catchment and CatchCN40 must remain binary identical w.r.t. what's on the develop branch.

@gmao-rreichle gmao-rreichle changed the title Updates to introduce new version of Catchment-CN: Catchment-CN5.1 FOR TESTING ONLY: Updates to introduce new version of Catchment-CN: Catchment-CN5.1 Jul 11, 2025
@gmao-rreichle gmao-rreichle changed the title FOR TESTING ONLY: Updates to introduce new version of Catchment-CN: Catchment-CN5.1 Updates to introduce new version of Catchment-CN: Catchment-CN5.1 Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants