revisions for handling of Nens and special nml and mwtrm path/files in coupled land-atm DAS #102
Conversation
remove command line inputs of the paths above
|
@gmao-rreichle the changes are tested by offline ldas setup with command line inputs. I consulted with Qing on special nml file content. the uploaded version here are based on what I have had, with minor edits on perturbation std ( updated to 3.0) and RTM_ID ( update to 4 ) . The zscore file and path remain same and need to be updated once we have newly estimated version. The mwtrm files ( C90, C180, C360 ) are already on SMAP project disk, I put it as default path in ldas_setup. |
gmao-rreichle
changed the title
…cific subdirectory (LDASsa_SPECIAL_inputs_ens*.nml)
…Ssa_SPECIAL_inputs_ensprop.nml)
- added comment about purpose of file - made consistent with latest version of LDASsa_DEFAULT_inputs_ensupd.nml - templated resolution-dependency of %scalepath and %scalename - replaced Discover physical path (/gpfsm/dnb..) with logical path
…nput files (CMakeLists.txt, ldas_setup)
gmao-rreichle
left a comment
gmao-rreichle
left a comment
There was a problem hiding this comment.
@saraqzhang : I revamped the processing of the special nml files and cleaned up the ensupd nml file. See my recent commits and the comments below.
…etup (ldas_setup)
…atm DAS (ldas_setup)
…Tb obs for coupled land-atm DAS (LandAtmDAS_nml/LDASsa_SPECIAL_inputs_ensupd.nml)
|
@saraqzhang : I made the changes we discussed this morning. I probably messed up somewhere, so please verify. I still plan to look into cleaning up the _rundir and _etcdir logic (see #102 (comment)), but I don't have time right now and will leave this for later. |
|
@gmao-rreichle a fix in Cmakelists subdir name. the action of getting special nml in etc/ to run/ is moved into the function createRCFiles(self) , where all rc etc in etc/ are handled to be copied and modified in run/. |
receive nens from fvsetup when ladas coupling atmens a minor fix to nml resolution insertion
|
@gmao-rreichle this commit adds getting nens from ldas ICS ( both det and ens). for coupling det there is no command line nens. for coupling atmens there is command line nens ( from fvsetup finding in atmens/ installed ) and it will be used. |
gmao-rreichle
left a comment
gmao-rreichle
left a comment
There was a problem hiding this comment.
@saraqzhang : I think we need to count the number of ens members in fvsetup. See comment below
|
@gmao-rreichle now nens to be find by fvsetup and passed to ldas_setup via commandline. Tested by runjob fvsetup calling ldas_setup. Corresponding changes to fvsetup are committed at adas PR#352 branch. |
gmao-rreichle
changed the title
|
Hi @saraqzhang, I added a few very minor cleanup changes (c834ecd) and a CHANGELOG.md entry. I started the 0-diff tests and will update the PR accordingly when I have the results. Assuming the 0-diff tests pass and you agree with my latest changes, the PR is ready for merging. |
|
@gmao-rreichle I will pull the final revision here and run a test. |
|
@gmao-rreichle the latest version passed setup test, ready to be merged. |
2 participants
Revised handling of configuration parameters in coupled land-atm DAS:
0-diff tests by @gmao-rreichle after commit af22d9a: