Fix sequence track when displaying multiple regions#724
Merged
garrettjstevens merged 5 commits intomainfrom Nov 4, 2025
Merged
Fix sequence track when displaying multiple regions#724garrettjstevens merged 5 commits intomainfrom
garrettjstevens merged 5 commits intomainfrom
Conversation
cmdcolin
pushed a commit
to cmdcolin/Apollo3
that referenced
this pull request
Mar 16, 2026
* Fix variable name * Don't draw frame colors outside displayed regions * Fix sequence not displaying sometimes * Use contentBlocks iterator * Factor track drawing into separate files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for a similar case to #721, but is actually for the Apollo Reference Sequence Track instead of the Apollo Annotation Track.
The sequence part of the track displayed ok with multiple displayed regions before this, but it didn't let the inter-region padding lines show through, and the highlighting was not working correctly. Comparison below with JBrowse sequence track also showing to show accuracy.
Before
After
Trying to update the drawing code to address #720 and #721 has proven difficult because that part of the code has gone through so many changes and additions. This is the first of probably several PRs to refactor the drawing code in a effort to make it easier to maintain.