forked from proroklab/VectorizedMultiAgentSimulator
-
Notifications
You must be signed in to change notification settings - Fork 0
Rezas expert #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RezaTorbati
wants to merge
13
commits into
main
Choose a base branch
from
RezasExpert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rezas expert #3
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
abdda38
Adding everything needed for proof of concept expert
RezaTorbati a85b4b3
Modified the expert to use continuous actions. Its still very not opt…
RezaTorbati 5fb3c6d
Cleaned up the expert code, loaded in the map, and added a bunch more…
RezaTorbati fbefc96
Adds obstacles from the map now, added a readme, and added an example…
RezaTorbati a0f99e2
Converted the ccbs expert to use diff drive instead of holonomic
RezaTorbati 3c8585f
Merge branch 'main' of github.com:GT-STAR-Lab/VectorizedMultiAgentSim…
RezaTorbati 8005434
properly reset environment with obstacles in navigation2
shalin-j ccf927a
update entity filter to include obstacles
shalin-j 413c4d7
add collision penalty for obstacles
shalin-j 387ad3b
Merge branch 'RezasExpert' of github.com:GT-STAR-Lab/VectorizedMultiA…
RezaTorbati df130c1
Think I updated what is needed in vmas for the expert
RezaTorbati cbe2594
saving trajectories now
RezaTorbati dc8c8fa
Simplified the format of the expert trajectories
RezaTorbati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <?xml version="1.0" ?> | ||
| <root> | ||
| <map> | ||
| <width>10</width> | ||
| <height>10</height> | ||
| <grid> | ||
| <row>0 1 0 0 0 0 0 0 0 0</row> | ||
| <row>0 1 0 0 0 0 0 0 0 0</row> | ||
| <row>0 1 0 0 0 0 0 0 0 0</row> | ||
| <row>0 1 0 0 0 0 0 0 0 0</row> | ||
| <row>0 1 0 0 0 0 0 0 0 0</row> | ||
| <row>0 1 0 0 0 0 0 0 0 0</row> | ||
| <row>0 1 0 0 0 0 0 0 0 0</row> | ||
| <row>0 1 0 0 0 0 0 0 0 0</row> | ||
| <row>0 1 0 0 0 0 0 0 1 1</row> | ||
| <row>0 0 0 0 0 0 0 0 0 0</row> | ||
| </grid> | ||
| </map> | ||
| </root> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| ## Using the expert | ||
|
|
||
| This program will load in the task logs in `log_dir` and use them to generate actions in the `navigation2` task. | ||
|
|
||
| Information about the arguments can be found by running `python3 NavigationExpert.py -h` | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add an example command |
||
| The grid_map.xml, config.xml, and task log files should all be taken from the CCBS fork. More information about these can be found there. | ||
|
|
||
| Make sure that the task log files are all named in the following manner: | ||
|
|
||
| `<anything you want>_<a unique number>_log.xml` | ||
|
|
||
| Current assumptions: | ||
| - Every file in `log_dir` that ends in `.xml` should be used | ||
| - All tasks use the same map | ||
| - The agents should definitely not collide. This leads to the agents driving relatively slowly. | ||
| - The `select_action` method can be modified to fix this but CCBS assumes all agents move at the same speed which is a big limiting factor. db-CBS may be able to help | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| <?xml version="1.0" ?> | ||
| <root> | ||
| <agent start_i="0" start_j="0" goal_i="0" goal_j="2"/> | ||
| <agent start_i="9" start_j="9" goal_i="0" goal_j="9"/> | ||
| <log> | ||
| <summary time="6.4941e-05" flowtime="31.828427124746192" makespan="20"/> | ||
| <agent number="0"> | ||
| <path duration="20"> | ||
| <section number="0" start_i="0" start_j="0" goal_i="1" goal_j="0" duration="1"/> | ||
| <section number="1" start_i="1" start_j="0" goal_i="2" goal_j="0" duration="1"/> | ||
| <section number="2" start_i="2" start_j="0" goal_i="3" goal_j="0" duration="1"/> | ||
| <section number="3" start_i="3" start_j="0" goal_i="4" goal_j="0" duration="1"/> | ||
| <section number="4" start_i="4" start_j="0" goal_i="5" goal_j="0" duration="1"/> | ||
| <section number="5" start_i="5" start_j="0" goal_i="6" goal_j="0" duration="1"/> | ||
| <section number="6" start_i="6" start_j="0" goal_i="7" goal_j="0" duration="1"/> | ||
| <section number="7" start_i="7" start_j="0" goal_i="8" goal_j="0" duration="1"/> | ||
| <section number="8" start_i="8" start_j="0" goal_i="9" goal_j="0" duration="1"/> | ||
| <section number="9" start_i="9" start_j="0" goal_i="9" goal_j="1" duration="1"/> | ||
| <section number="10" start_i="9" start_j="1" goal_i="9" goal_j="2" duration="1"/> | ||
| <section number="11" start_i="9" start_j="2" goal_i="8" goal_j="2" duration="1"/> | ||
| <section number="12" start_i="8" start_j="2" goal_i="7" goal_j="2" duration="1"/> | ||
| <section number="13" start_i="7" start_j="2" goal_i="6" goal_j="2" duration="1"/> | ||
| <section number="14" start_i="6" start_j="2" goal_i="5" goal_j="2" duration="1"/> | ||
| <section number="15" start_i="5" start_j="2" goal_i="4" goal_j="2" duration="1"/> | ||
| <section number="16" start_i="4" start_j="2" goal_i="3" goal_j="2" duration="1"/> | ||
| <section number="17" start_i="3" start_j="2" goal_i="2" goal_j="2" duration="1"/> | ||
| <section number="18" start_i="2" start_j="2" goal_i="1" goal_j="2" duration="1"/> | ||
| <section number="19" start_i="1" start_j="2" goal_i="0" goal_j="2" duration="1"/> | ||
| </path> | ||
| </agent> | ||
| <agent number="1"> | ||
| <path duration="11.82842712474619"> | ||
| <section number="0" start_i="9" start_j="9" goal_i="9" goal_j="8" duration="1"/> | ||
| <section number="1" start_i="9" start_j="8" goal_i="9" goal_j="7" duration="1"/> | ||
| <section number="2" start_i="9" start_j="7" goal_i="8" goal_j="7" duration="1"/> | ||
| <section number="3" start_i="8" start_j="7" goal_i="7" goal_j="7" duration="1"/> | ||
| <section number="4" start_i="7" start_j="7" goal_i="6" goal_j="8" duration="1.4142135623730949"/> | ||
| <section number="5" start_i="6" start_j="8" goal_i="5" goal_j="9" duration="1.4142135623730949"/> | ||
| <section number="6" start_i="5" start_j="9" goal_i="4" goal_j="9" duration="1"/> | ||
| <section number="7" start_i="4" start_j="9" goal_i="3" goal_j="9" duration="1"/> | ||
| <section number="8" start_i="3" start_j="9" goal_i="2" goal_j="9" duration="1"/> | ||
| <section number="9" start_i="2" start_j="9" goal_i="1" goal_j="9" duration="1"/> | ||
| <section number="10" start_i="1" start_j="9" goal_i="0" goal_j="9" duration="1"/> | ||
| </path> | ||
| </agent> | ||
| </log> | ||
| </root> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't appear to actually run the expert algorithm, rather it constructions the agent action from the expert. Do you plan to merge the expert into this file? Maybe we call this file something like navigation_select_actions_from_expert.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you anticipate we will integrate these expert demonstrations into the RLPD architecture. I imaging that the files in log_dir will act like our expert dataset, which we will then call to rollout an episode on the environment. Before pushing this to main, I think we should figure out this integration. For example, I think we could create Collector class that does "symmetric sampling", wherein it pulls have the batch from the expert and half from the policy. See the following link: https://pytorch.org/rl/reference/collectors.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified this file runs! Good job