Specialize Clone impl for Box to use Crucible's allocator#247
Merged
RyanGlScott merged 1 commit intomasterfrom Feb 27, 2026
Merged
Specialize Clone impl for Box to use Crucible's allocator#247RyanGlScott merged 1 commit intomasterfrom
Clone impl for Box to use Crucible's allocator#247RyanGlScott merged 1 commit intomasterfrom
Conversation
RyanGlScott
added
the
standard libraries
samcowger
reviewed
Feb 27, 2026
RyanGlScott
force-pushed
the
T245-box-clone-patch
branch
from
be8d2e9 to
6fadf27
Compare
spernsteiner
approved these changes
Feb 27, 2026
Collaborator
spernsteiner
left a comment
spernsteiner
left a comment
There was a problem hiding this comment.
I was a bit nervous seeing specialization here, since I know it still has major unsoundness, but I checked the alloc/src/lib.rs and apparently it's only using feature(min_specialization), which is described as "A minimal, sound subset of specialization intended to be used by the standard library until the soundness issues with specialization are fixed." So this should be fine.
RyanGlScott
force-pushed
the
T245-box-clone-patch
branch
from
6fadf27 to
0cf2165
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245.