Fix Switch controller initialization race condition#188
Merged
GaryOderNichts merged 3 commits intoGaryOderNichts:mainfrom Aug 24, 2025
Merged
Fix Switch controller initialization race condition#188GaryOderNichts merged 3 commits intoGaryOderNichts:mainfrom
GaryOderNichts merged 3 commits intoGaryOderNichts:mainfrom
Conversation
Switch controllers require ACK responses between initialization commands to process them correctly. The previous implementation sent setPlayerLeds(), setVibration(), and readSpiFlash() commands in rapid succession without waiting for acknowledgments, causing race conditions. Changes: - Restructured command sequence to wait for each ACK before sending next command - setPlayerLeds() now triggers setVibration() on ACK - setVibration() now triggers calibration reads on ACK - Ensures proper controller state before attempting calibration data reads
Remove Extra Spaces
- Add early return for command response containing LED set command ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch controllers require ACK responses between initialization commands to process them correctly. The previous implementation sent setPlayerLeds(), setVibration(), and readSpiFlash() commands in rapid succession without waiting for acknowledgments, causing race conditions.
Changes: