Skip to content

Fix Switch controller initialization race condition #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaryOderNichts merged 3 commits into from
Aug 24, 2025
Merged

Fix Switch controller initialization race condition #188

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b90241c
Fix Switch controller initialization race condition
mitchellcairns Aug 3, 2025
3f470e6
Update switch_controller.c
mitchellcairns Aug 4, 2025
f1dc620
Update switch_controller.c
mitchellcairns Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ios/ios_pad/source/controllers/switch_controller.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,11 +465,11 @@ static void handle_command_response(Controller* controller, SwitchCommandRespons

// set the leds now that we know the device type
setPlayerLeds(controller);

} else if (resp->command == SWITCH_COMMAND_SET_PLAYER_LEDS) {
// enable rumble
setVibration(controller, 1);

/* Calibration causes issues for third-party controllers */
} else if (resp->command == SWITCH_COMMAND_ENABLE_VIBRATION) {
/* Calibration causes issues for some third-party controllers */
if ((sdata->device == SWITCH_DEVICE_JOYCON_LEFT || /*sdata->device == SWITCH_DEVICE_TP_JOYCON_LEFT ||*/
sdata->device == SWITCH_DEVICE_JOYCON_RIGHT || /*sdata->device == SWITCH_DEVICE_TP_JOYCON_RIGHT ||*/
sdata->device == SWITCH_DEVICE_PRO || /*sdata->device == SWITCH_DEVICE_TP_PRO ||*/
Expand Down