Fixed warnings for ROS2 Humble#2
Open
FranzAlbers wants to merge 1 commit intoGeneSysElektronik:ros2_masterfrom
Open
Fixed warnings for ROS2 Humble#2FranzAlbers wants to merge 1 commit intoGeneSysElektronik:ros2_masterfrom
FranzAlbers wants to merge 1 commit intoGeneSysElektronik:ros2_masterfrom
Conversation
Collaborator
|
Thank you for your response. I also had these deprecated warnings with ROS2 Humble, but at the moment we don't have enough informations about the mostly used ROS distribution. We will discuss internaly which distribution will be our main one (master branch) and how to handle legacy versions. Until then, this PR will leaved open. |
Contributor
Author
|
Thanks for merging the other PRs! ROS2 Galactic reached its end of life in December 2022, and Foxy will follow in May 2023 (https://docs.ros.org/en/rolling/Releases.html). I propose to keep the main branch up to date for current distributions: Either for Humble as the current long-term-support version (until 2027) or for Rolling with an additional branch for Humble. This fix is necessary for both. |
rschilli-dev
added a commit
that referenced
this pull request
Aug 17, 2023
See PR #2 for the discussion...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ROS2 Humble, you receive the following warnings when building the driver:
This PR fixes these warnings.
Since the
tf2_geometry_msgs.hppwas introduced in Humble, this probably breaks the Galactic build (which could be moved to another branch).