Skip to content

pygmt.grdsample: Migrate the 'translate' parameter to the new alias system #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seisman merged 2 commits into from
Nov 3, 2025
Merged

pygmt.grdsample: Migrate the 'translate' parameter to the new alias system #4185

seisman merged 2 commits into from
Nov 3, 2025

Conversation

@seisman
Copy link
Member

@seisman seisman commented Nov 2, 2025

No description provided.

@seisman seisman added this to the 0.18.0 milestone Nov 2, 2025
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels Nov 2, 2025
@seisman seisman mentioned this pull request Nov 2, 2025
Merged
weiji14
weiji14 approved these changes Nov 2, 2025
View reviewed changes
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Nov 3, 2025
@seisman seisman merged commit c74e4af into main Nov 3, 2025
22 of 23 checks passed
@seisman seisman deleted the grdsample/translate branch November 3, 2025 01:22
@seisman
Copy link
Member Author

seisman commented Nov 3, 2025

In addition to grdsample, there are other modules (grdedit, grdfilter, dimfilter) that also have the same option.

Currently, it's aliased to translate in grdsample, but is aliased to toggle in grdfilter. GMT recommends toggle/toggle_registration

https://github.com/GenericMappingTools/gmt/blob/21a81c7354a76e17584870f8ef0cf73ad5d23c1c/src/longopt/grdsample_inc.h#L30

Maybe we should use toggle consistently?

@weiji14
Copy link
Member

weiji14 commented Nov 3, 2025

Sure, toggle sounds good.

This was referenced Nov 3, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman @weiji14