Skip to content

Conversation

@yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Jan 13, 2026

Description of proposed changes

Remove the no_data parameter of pygmt.grdfill (deprecated since v0.15.0).

Would wait some days with merging this PR, in case we need to make a patch release.

Guidelines

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added this to the 0.19.0 milestone Jan 13, 2026
@yvonnefroehlich yvonnefroehlich self-assigned this Jan 13, 2026
@yvonnefroehlich yvonnefroehlich added the deprecation Deprecating a feature label Jan 13, 2026
@yvonnefroehlich yvonnefroehlich changed the title pygmt.grdfill: Remove parametr 'no_data' (Deprecated since v0.15.0) pygmt.grdfill: Remove parameter 'no_data' (Deprecated since v0.15.0) Jan 13, 2026
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will merge on Jan. 18.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jan 13, 2026
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 17, 2026
@seisman seisman merged commit 88dcf01 into main Jan 17, 2026
22 of 23 checks passed
@seisman seisman deleted the remove-grdfill-no_data branch January 17, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants