Skip to content

pygmt.grdfill: Remove parameter 'no_data' (Deprecated since v0.15.0) #4344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 3 commits into from
Jan 17, 2026
Merged

pygmt.grdfill: Remove parameter 'no_data' (Deprecated since v0.15.0) #4344

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81ac6d6
Remove parameter 'no_data'
yvonnefroehlich Jan 13, 2026
98b7cff
Remove test for parameter 'no_data'
yvonnefroehlich Jan 13, 2026
65abff8
Merge branch 'main' into remove-grdfill-no_data
seisman Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pygmt/src/grdfill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,7 @@ def _validate_params(


@fmt_docstring
# TODO(PyGMT>=0.19.0): Remove the deprecated 'no_data' parameter.
# TODO(PyGMT>=0.19.0): Remove the deprecated 'mode' parameter.
@deprecate_parameter("no_data", "hole", "v0.15.0", remove_version="v0.19.0")
@deprecate_parameter(
"constantfill", "constant_fill", "v0.18.0", remove_version="v0.20.0"
)
Expand Down
6 changes: 0 additions & 6 deletions pygmt/tests/test_grdfill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,6 @@ def test_grdfill_hole(grid, expected_grid):
assert result.gmt.registration is GridRegistration.PIXEL
xr.testing.assert_allclose(a=result, b=expected_grid)

# Test the deprecated 'no_data' parameter.
# TODO(PyGMT>=0.19.0): Remove the following lines.
with pytest.warns(FutureWarning):
result2 = grdfill(grid=grid_no_nan, constant_fill=20, no_data=-99999)
xr.testing.assert_allclose(a=result2, b=expected_grid)


def test_grdfill_inquire(grid):
"""
Expand Down
Loading