CI: Combine the steps for building GMT source code in the 'GMT Dev Tests' workflow

[seisman]

With changes in #4329, now it's possible to have a single step for building GMT source code on all platforms.

[weiji14]

Can probably remove this since already set in defaults above. Should have done this in #4329 (comment)

Suggested change

shell: bash -l {0}

[weiji14]

See if this would work, based on https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#example

Suggested change

	GMT_INSTALL_DIR: ${{ runner.temp }}/gmt-install-dir
	CMAKE_PREFIX_PATH: ${{ startsWith(matrix.os, 'windows') && '' || '-DCMAKE_PREFIX_PATH=$MAMBA_ROOT_PREFIX/envs/pygmt/Library' }}
	GMT_INSTALL_DIR: ${{ runner.temp }}/gmt-install-dir

[seisman]

I didn't try this, because now we need to set CMAKE_PREFIX_PATH to different values based on the OS.

[weiji14]

Suggested change

	CMAKE_PREFIX_PATH="-DCMAKE_PREFIX_PATH=$MAMBA_ROOT_PREFIX/envs/pygmt/Library"
	else
	CMAKE_PREFIX_PATH=""

[seisman]

Still not lucky. It seems that we need shell: bash -l ${0} (the default) for macOS/Linux but shell: bash for Windows.

[seisman]

Still not lucky. It seems that we need shell: bash -l ${0} (the default) for macOS/Linux but shell: bash for Windows.

I still don’t fully understand the underlying cause, but the observation appears reliable.

On Windows, the login shell seems to interfere with the Visual Studio activation script ("C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"), so a non-login shell is required and CMAKE_PREFIX_PATH must point to "$MAMBA_ROOT_PREFIX/envs/pygmt/Library".

On Linux/macOS, a login shell automatically activates the environment, and CMake locates the libraries without help; with a non-login shell, we need to set CMAKE_PREFIX_PATH to "$MAMBA_ROOT_PREFIX/envs/pygmt".

Now building source codes succeeds on all platforms. The failing test is unrelated.

CI Runs: https://github.com/GenericMappingTools/pygmt/actions/runs/20982948742

[weiji14]

Looks good. Just curious though, you know what's up with the skipped job at https://github.com/GenericMappingTools/pygmt/actions/runs/20982938310/job/60311514437?