Skip to content

CI: Combine the steps for building GMT source code in the 'GMT Dev Tests' workflow #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 9 commits into from
Jan 14, 2026
+9 −23
Merged

CI: Combine the steps for building GMT source code in the 'GMT Dev Tests' workflow #4353

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d828fef
CI: Combine the steps for building GMT source code in the 'GMT Dev Te…
seisman Jan 14, 2026
e01666d
Use bash -l -zsh
seisman Jan 14, 2026
b4d87dc
Remove the 'shell' setting
seisman Jan 14, 2026
87c7542
Remove the build directory rather than the gmt source code directory
seisman Jan 14, 2026
92c2432
Use no-login shell
seisman Jan 14, 2026
00cee76
Set CMAKE_LIBRARY_PATH on all platforms
seisman Jan 14, 2026
83ed842
Fix CMAKE_PREFIX_PATH for Linux/macOS
seisman Jan 14, 2026
874b185
Use non-login shell on Windows and login shell on Linux/macOS
seisman Jan 14, 2026
290e57b
Revert "Use non-login shell on Windows and login shell on Linux/macOS"
seisman Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions .github/workflows/ci_tests_dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,44 +103,30 @@ jobs:

# Build GMT from source on Linux/macOS, script is adapted from
# https://github.com/GenericMappingTools/gmt/blob/6.5.0/ci/build-gmt.sh
- name: Build GMT on Linux/macOS
run: |
cd gmt/
mkdir build
cd build
cmake -G Ninja .. \
-DCMAKE_INSTALL_PREFIX=${GMT_INSTALL_DIR} \
-DCMAKE_BUILD_TYPE=Release \
-DGMT_ENABLE_OPENMP=TRUE \
-DGMT_USE_THREADS=TRUE
cmake --build .
cmake --build . --target install
cd ..
rm -rf gmt/
env:
GMT_INSTALL_DIR: ${{ runner.temp }}/gmt-install-dir
if: runner.os != 'Windows'

- name: Build GMT on Windows
- name: Build GMT from source
shell: bash
run: |
cd gmt/
mkdir build
cd build
cmd.exe /c "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
if [[ "$RUNNER_OS" == "Windows" ]]; then
cmd.exe /c "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
CMAKE_PREFIX_PATH="$MAMBA_ROOT_PREFIX/envs/pygmt/Library"
else
CMAKE_PREFIX_PATH="$MAMBA_ROOT_PREFIX/envs/pygmt"
fi
cmake -G Ninja .. \
-DCMAKE_PREFIX_PATH="$CMAKE_PREFIX_PATH" \
-DCMAKE_INSTALL_PREFIX="$GMT_INSTALL_DIR" \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_PREFIX_PATH="$MAMBA_ROOT_PREFIX/envs/pygmt/Library" \
-DGMT_ENABLE_OPENMP=TRUE \
-DGMT_USE_THREADS=TRUE
cmake --build .
cmake --build . --target install
cd ..
rm -rf gmt/
rm -rf build
env:
GMT_INSTALL_DIR: ${{ runner.temp }}/gmt-install-dir
Copy link
Member

@weiji14 weiji14 Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if this would work, based on https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#example

Suggested change
GMT_INSTALL_DIR: ${{ runner.temp }}/gmt-install-dir
CMAKE_PREFIX_PATH: ${{ startsWith(matrix.os, 'windows') && '' || '-DCMAKE_PREFIX_PATH=$MAMBA_ROOT_PREFIX/envs/pygmt/Library' }}
GMT_INSTALL_DIR: ${{ runner.temp }}/gmt-install-dir

Copy link
Member Author

@seisman seisman Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try this, because now we need to set CMAKE_PREFIX_PATH to different values based on the OS.

if: runner.os == 'Windows'

- name: Add GMT's bin to PATH
run: echo '${{ runner.temp }}/gmt-install-dir/bin' >> $GITHUB_PATH
Expand Down
Loading