[BUG FIX][MISC] Update IMU #1962
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Milotrince
commented
Nov 9, 2025
Comment on lines
-123
to
-130
| @gs.assert_built | ||
| def set_acc_bias(self, bias, envs_idx=None): | ||
| self._set_metadata_field(bias, self._shared_metadata.acc_bias, field_size=3, envs_idx=envs_idx) | ||
|
|
||
| @gs.assert_built | ||
| def set_gyro_bias(self, bias, envs_idx=None): | ||
| self._set_metadata_field(bias, self._shared_metadata.gyro_bias, field_size=3, envs_idx=envs_idx) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
removed the set_acc_* and set_gyro_* functions since can use set_* from the NoisySensorMixin instead; having these APIs introduce duplicity and also don't work properly in some cases because of tensor copying not modifying the original metadata field
YilingQiao
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
axes_skewtocross_axis_couplingfor clarityRelated Issue
Resolves #1959
Motivation and Context
How Has This Been / Can This Be Tested?
Updated
test_sensors.py::test_imu_sensorScreenshots (if appropriate):
Checklist:
Submitting Code Changessection of CONTRIBUTING document.