Open
Conversation
… vsync framerate)
…s because the samples are sorted)
Reduce decimation to 8000 (instead of 200000) which still give 2 points per pixel on a 4K display
- thread it - dynamically adapt the unit change tooltip for a cross for better readability and improve the snapping to not miss points
trns1997
reviewed
Mar 23, 2026
| Serie::Serie(std::string const& name, std::vector<Point>&& raw_serie, ImVec4 color) | ||
| { | ||
| constexpr uint32_t DECIMATION = 200'000; | ||
| constexpr uint32_t DECIMATION = 8'000; |
Contributor
There was a problem hiding this comment.
Any particular reason why this changed ? Is there a preference for smaller sections?
trns1997
reviewed
Mar 23, 2026
| double abs_val = std::abs(seconds); | ||
|
|
||
| if (abs_value >= 31536000) // Years (365 days) | ||
| if (abs_val >= 31536000) |
Contributor
There was a problem hiding this comment.
Keep comments they help with readability
trns1997
reviewed
Mar 23, 2026
| { | ||
| if (serie_.empty()) | ||
| { | ||
| //TODO: Display something to say its empty? |
Contributor
There was a problem hiding this comment.
Add back todo. This is useful to add later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GUI is unusable as soon as there is too many curves (even if not big: my test sample is 11 curves of 4minutes each).
This PR improve the GUI performance and usability: now the test sample is roughly around ~60% CPU on my mpachine when displaying everything, without the feeling of sluggishness